Can no longer see edges of selections

[grayman]

As recently as pre-1.8.1, I relied on the ability to see a highlighted selection in the camera view, like this:

 

 

This was quite useful when looking for a particular brush using the "Find Brush" feature, typing in the brush number, and backing out of the map in the camera view until the highlighted edges of the sought brush were visible. Then I could fly the camera to the brush and do what I needed to do there.

 

The same technique worked for finding entities.

 

Now, in final-1.8.1, this behavior has changed, such that highlighted edges of whatever's selected are hidden by objects closer to the camera, like this:

 

 

This makes the "Find Brush or Entity" feature much less useful, because when backing out of the map in the camera view, the sought object's highlighted edges are hidden. So I can't see it.

 

Can we get back the previous behavior? Was it removed for a particular reason, or just the side effect of fixing something else?

[Bikerdude]

As Greebo is working on version 2.0 I imagine he would like a bug tracker for it and post it in the Darkradiant wxWidgets thread

[greebo]

grayman, which version was exactly the one that was working ok? I can try to narrow down the commit that broke that behaviour in 1.8.1.

 

Depending on how much time it takes to stabilise 2.0.0 and how much work the fix for this issue is, it might be possible that this problem will be addressed in the 1.8.x branch as well.

[grayman]

Since I had overwritten my 1.8.1pre version with the final 1.8.1 version, and only later discovered this problem, I had to go back through the DR 1.8.1 beta test thread and find a link to a 1.8.1pre version. The only one I could find was the Feb 12 build, so that's the one I'm currently using. I'm pretty sure there were pre builds later than that, and I know I was using the last of those before I clobbered it. Whichever version came before the final version exhibited the behavior I need.

 

Thanks.

[greebo]

Ok, got the revision, it has been introduced in a29b8ee725582665a792388a4ffc433f296c78e0, which is the commit allowing selected patches to be visible from behind. Investigating now what exactly caused the side effect on brushes.

 

edit: well ok it's pretty obvious since this block has been removed from $CAM_OVERLAY:

 

// Second pass for hidden lines
OpenGLState& hiddenLine = appendDefaultPass();
hiddenLine.setColour(0.75, 0.75, 0.75, 1);
hiddenLine.setRenderFlags(RENDER_CULLFACE| RENDER_DEPTHTEST| RENDER_OFFSETLINE| RENDER_LINESTIPPLE);
hiddenLine.setSortPosition(OpenGLState::SORT_OVERLAY_FIRST);
hiddenLine.setDepthFunc(GL_GREATER);
hiddenLine.m_linestipple_factor = 2;

[Bikerdude]

Nice one Greebo.

[greebo]

OK, fixed in source. I pushed the changes to the 1.8.x branch at orbweaver's repo too.

[grayman]

Thank you.