Jump to content
The Dark Mod Forums

WindowPosition::saveToNode()


Recommended Posts

I noticed while engaged in the PersistentTransientWindow refactor that WindowPosition has the following method:

 

void WindowPosition::saveToNode(xml::Node node) {
node.setAttributeValue("xPosition", intToStr(_position[0]));
node.setAttributeValue("yPosition", intToStr(_position[1]));
node.setAttributeValue("width", intToStr(_size[0]));
node.setAttributeValue("height", intToStr(_size[1]));
}

 

At first glance, this method appears to do absolutely nothing, since the xml::Node is passed by value not by reference and therefore the changes are only made to a temporary copy.

 

However, I guess this still works because xml::Node is just a wrapper for an xmlNode* pointer, which will still point to the same xmlNode even when the xml::Node object is copied. Was this the intention? It seems dangerous to me because there is no guarantee that copying an xml::Node will still point to the same xmlNode, even if it does at present.

 

(For absolute correctness, xml::Node should have a copy-constructor defined which performs a deep copy of the underlying structures, so that copy semantics work as expected, but this is probably not worth it in reality).

Link to comment
Share on other sites

I certainly didn't intend the xml::Node to be passed by value, thanks for catching that one. Yes, it works because the contained pointer is still the same, that's probably why I didn't notice this.

 

Could you change it to take a reference or should I do it?

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

  • Recent Status Updates

    • Ansome

      Finally got my PC back from the shop after my SSD got corrupted a week ago and damaged my motherboard. Scary stuff, but thank goodness it happened right after two months of FM development instead of wiping all my work before I could release it. New SSD, repaired Motherboard and BIOS, and we're ready to start working on my second FM with some added version control in the cloud just to be safe!
      · 0 replies
    • Petike the Taffer  »  DeTeEff

      I've updated the articles for your FMs and your author category at the wiki. Your newer nickname (DeTeEff) now comes first, and the one in parentheses is your older nickname (Fieldmedic). Just to avoid confusing people who played your FMs years ago and remember your older nickname. I've added a wiki article for your latest FM, Who Watches the Watcher?, as part of my current updating efforts. Unless I overlooked something, you have five different FMs so far.
      · 0 replies
    • Petike the Taffer

      I've finally managed to log in to The Dark Mod Wiki. I'm back in the saddle and before the holidays start in full, I'll be adding a few new FM articles and doing other updates. Written in Stone is already done.
      · 4 replies
    • nbohr1more

      TDM 15th Anniversary Contest is now active! Please declare your participation: https://forums.thedarkmod.com/index.php?/topic/22413-the-dark-mod-15th-anniversary-contest-entry-thread/
       
      · 0 replies
    • JackFarmer

      @TheUnbeholden
      You cannot receive PMs. Could you please be so kind and check your mailbox if it is full (or maybe you switched off the function)?
      · 1 reply
×
×
  • Create New...