Trying to create a new Gaslight entity:

[Bikerdude]

So created a new light entity and checked it works -

 

entitydef light_gasflame
{
"inherit"	"light_extinguishable"
"editor_usage"   "Static gas flame with glare"
"editor_displayFolder" "Lights/Light Sources/Gas Flames"
"mins" "-1 -1 -2"
"maxs" "1 1 2"
"model_lit"	"tdm_fire_gaslight_glare_02.prt"
"model_extinguished" "tdm_smoke_candleout.prt"

"falloff"	"0"
"texture"	"lights/biground_candleflicker_shadow"
"_color"	"0.80 0.6 0.23"
"light_radius"   "130 130 110"
"snd_lit"	""
"snd_extinguished"  "tdm_candle_extinguish"
"should_be_vert"  "1" // grayman #2603 - douse if flame orientation is > 45 degrees from vertical
}

 

But when I attached the new light source to the lamp_wall_gaslight entity, it dosent appear.

 

entityDef atdm:lamp_wall_gaslight04
{
   "inherit"                            "atdm:static_electric_light_unlit_base"
   "model"                                "models/darkmod/lights/extinguishable/wall_gaslight03.lwo"
   "editor_setKeyValue model"            "models/darkmod/lights/extinguishable/wall_gaslight03.lwo"
   "editor_displayFolder"                "Lights/Model Lights, Static/Switchable/Gas/DoNotUse/Deprecated"
   "editor_usage"                        "An unlit wall-mounted gas lamp with an open top. Can be toggled on/off when linked from a switch."

   "light_radius"                        "260 260 260"
   "_color"                            "0.60 0.50 0.30"

   "skin"                                "lights/gaslight_brass_unlit"
   "skin_lit"                            "lights/gaslight_brass_noshadow_fix"
   "skin_unlit"                        "lights/gaslight_brass_unlit"
   "texture"                            "lights/biground1"

   "s_volume"                            "-25"
   "s_waitfortrigger"                    "0"

   // need a better sound
   "s_shader"                            "gaslight"

   // add the spawnarg in the editor, to allow easier changing
   "editor_SetKeyValue s_shader"        "gaslight"

   "extinguished"                        "1"

   "light_center"                        "-1 0 7"
   "editor_setKeyValue light_center"    "-1 0 7"
}

entityDef atdm:lamp_wall_gaslight_04_lit
{
   "inherit"                            "atdm:lamp_wall_gaslight03"
   "model"                                "models/darkmod/lights/extinguishable/wall_gaslight03.lwo"
   "editor_setKeyValue model"            "models/darkmod/lights/extinguishable/wall_gaslight03.lwo"
   "editor_displayFolder"                "Lights/Model Lights, Static/Switchable/Gas"
   "editor_usage"                        "A lit wall-mounted gas lamp with an open top. Can be toggled on/off when linked from a switch."

   "extinguished"                        "0"
   "skin"                                "lights/gaslight_brass_noshadow_fix"

}

[Springheel]

Can you post this entity?

 

"tdm_fire_gaslight_glare_02"

[Bikerdude]

Its just a particle, do I need to make that into an light entity....?

[Springheel]

If it's a particle I think it should have a .prt extension.

[Bikerdude]

Ah ok, let me try that.

Looks like Im gonna have to create a new light entity def with the partical included.

[Bikerdude]

Update the OP, as I still cant figure out why this isnt working, I've attached a test map.

 

I think I might be doubling up on the number of lights sources and what I might need to do is create a new light entity base. That said, my original objective was just to add a particle effect to the gaslight entities.

 

Figured it out, has to change the inherited entities from -

 

entityDef atdm:lamp_wall_gaslight04
{
"inherit"							"atdm:static_electric_light_unlit_base"

and

entityDef atdm:lamp_wall_gaslight_04_lit
{
"inherit"							"atdm:lamp_wall_gaslight03"

to

entityDef atdm:lamp_wall_gaslight04
{
"inherit"							"atdm:lamp_gaslight"

and

entityDef atdm:lamp_wall_gaslight_04_lit
{
"inherit"							"atdm:lamp_wall_gaslight04"

 

The primary inherited arg of "atdm:lamp_gaslight" was key, it seems the "static_electric_light_unlit_base" did not want to play ball with my new light source.

[Bikerdude]

Ok, it seems I am doubling up on light sources and I haven't been able to figure out why -

entityDef atdm:lamp_wall_gaslight04
{
   "inherit"                            "atdm:lamp_gaslight"
   "model"                                "models/darkmod/lights/extinguishable/wall_gaslight03.lwo"
   "editor_setKeyValue model"            "models/darkmod/lights/extinguishable/wall_gaslight03.lwo"
   "editor_displayFolder"                "Lights/Model Lights, Static/Switchable/Gas/DoNotUse/Deprecated"
   "editor_usage"                        "An unlit wall-mounted gas lamp with an open top. Can be toggled on/off when linked from a switch."

   "light_radius"                        "260 260 260"
   "_color"                            "0.60 0.50 0.30"

   // attach the missing gas flame & glare
   "def_attach"            "light_gasflame"
   "pos_attach"            "flame"        // At the attach point called "flame"...
   "attach_pos_name_1"        "flame"        // ... which is defined here.
   "name_attach"            "flame"        // Give it a name to pass along spawnargs
   "attach_pos_origin_1"    "-1 0 7"    // Offset the flame X units in the Z direction

   "skin"                                "lights/gaslight_brass_unlit"
   "skin_lit"                            "lights/gaslight_brass_noshadow_fix"
   "skin_unlit"                        "lights/gaslight_brass_unlit"
   "texture"                            "lights/biground1"

   "s_volume"                            "-25"
   "s_waitfortrigger"                    "0"

   // bikerdude created a better sound.
   "s_shader"                            "gaslight"

   // add the spawnarg in the editor, to allow easier changing
   "editor_SetKeyValue s_shader"        "gaslight"

   "extinguished"                        "1"

   "light_center"                        "-1 0 7"
   "editor_setKeyValue light_center"    "-1 0 7"
}

[Obsttorte]

If you attach a light to your gaslamp, why do you let the lamp itself emit light, too?

 

Btw.: If the light comes from an attachment, the entity you attach it to should be a func_static, not a light entity, too.

[Bikerdude]

Hey obs

 

I have never done this before so I am kinda grabbing at straws, I thoguht it would be a simple case of look at an existing lighht entity with flame based particle and change all the details to suit.

 

I dont fully understand what Im doing wrong or right, spent 3 hours last night and then gave up and went to bed.

[Obsttorte]

You attached a light entity to an light entity, so both the attached entity and the entity you have attached it to are emitting a light. Simple as that

[Bikerdude]

ok, so how do I attach a single particle - which is what i was trying to do to begine with.

[SteveL]

Just trying to figure this out myself. The atdm:lamp_gaslight is a light that has a lamp model specified. So its model slot is used up already and you can't add a particle. To add anything else you'll need to def_attach it like you are doing. Your light_gasflame is another light that but one that has a particle as its model, so attaching that you get the particle but end up with 2 lights.

 

You could make a new entity def that inherits "func_emitter" and that specifies the particle as its model, then def_attach that. That way you get the particle without the extra light. But it probably won't toggle off when you switch the light off.

 

You'd probably be better off starting with a torch entity def and adapting it. Change the torch model for the lamp, and the def_attached light to your light_gasflame.

 

There are two completely different types of entity light in TDM -- the ones with particles like torches have a static model as the base entity, and they def_attach a light that has a particle effect. The other ones like electric lamps have a light as the base entity, with a visible "model" specified instead of a particle. Right now the gaslamp is the second type, but you probably want to change it to the first type so that the particle stays in sync with the light.

[Bikerdude]

You'd probably be better off starting with a torch entity def and adapting it. Change the torch model for the lamp, and the def_attached light to your light_gasflame.

Will have a go that this.

[Obsttorte]

To attach a particle to any other entity, create a custom particle entity like this:

entityDef nameOfMyEntity
{
 "inherit"  "func_emitter" //fs also works, but this way it is more clearer what it does
 "model"  "spectacularParticle.prt" //points to the particle to use
}

You can now attach this entity via an entityDef or simple create this entity in DR and manualy bind it to any entity.

[Bikerdude]

The original idea was to try and reduce the entity coun in the map by having a single entity with all the requred items (model, light, particle) etc. Also another advantage of this is the particle will switch off when you switch the light off.

 

And on a related note, correct me if Im wrong but I dont think we have any particle entites like that in the mod?

[Obsttorte]

And on a related note, correct me if Im wrong but I dont think we have any particle entites like that in the mod?

Aaaaand ... ?

The original idea was to try and reduce the entity coun in the map by having a single entity with all the requred items (model, light, particle) etc. Also another advantage of this is the particle will switch off when you switch the light off.

You can either use a light entity with the lamp as model and a particle def_attached to it or a light entity with the particle as a model def attached to a func_static having the lamp as a model. I don't think one entity can have several models,a lthough I never tried to be honest.

 

So in any way I think you need two entities anyway.

[SteveL]

I don't think one entity can have several models,a lthough I never tried to be honest.

That's right. There's code for one func emitter to have several particles, but it's not been extended to allow one static entity to have several models.

[Obsttorte]

There's code for one func emitter to have several particles

At the same time?

[SteveL]

Yes.... I've not tested it but there's code to let you specify model, model_1, model_2 etc along with offset_1 offset_2

[OrbWeaver]

It is in fact possible to have light, model and particle on the same entity: instead of using def_attach to spawn additional particle/light entities on a base entity, you just make a light or editor_light, give it a "model" spawnarg pointing to your lamp model, and in the model itself you add a single triangle which is the emitter and use a material with the "deform particle" declaration to turn that triangle into a particle emitter rather than rendered geometry.

 

However this does require adding the emitter triangle in the model itself using a 3D application, which might be tricky if you are not used to 3D modelling or you want to use an existing model that isn't in a format you can edit. On the other hand it would achieve the goal of using only a single entity in the map.

[SteveL]

That's clever. I'd never thought of that. How would you tell it which particle to play? Does that go in the material file too?

[OrbWeaver]

That's clever. I'd never thought of that. How would you tell it which particle to play? Does that go in the material file too?

 

Yep. Check out the entry for "deform particle" in this page. The particle declname goes right after the keyword.

 

I guess you might actually want "deform particle2" which doesn't vary the particle count based on triangle area. I think the first one is designed for the sort of "burning flesh" demon effects in D3 where the actual surface of a monster seems to be on fire.

 

Oh, and in anticipation of the follow-up question "But how would you switch the particles off when the torch is extinguished?", this ought to be trivial using a skin.

[Tels]

Yes.... I've not tested it but there's code to let you specify model, model_1, model_2 etc along with offset_1 offset_2

 

I'm probably responsible for this, as I added it back when I wanted SEED to be able to combine multiple emitters into one entity. But I never extended it to multi-models in general, and also the specification of the emitters is very clumsy (manually adding the offsets is not fun).

 

Technically, however, multiple models per entity should be easy, instead of just presenting the "one and only" model to the renderer (and saving its renderhandle), present multiple models to the renderer and store (and save/load) all render handles.

 

Basically just extending the scalar var into an array.

[Bikerdude]

@Tels - I'm gonna have a go at tweaking a torch entity, but if that dosent work Im gonna drop you a pM.