Jump to content
The Dark Mod Forums

Problem with purse frobbox_size in 2.05


grayman

Recommended Posts

In 2.05, it was decided to add a frobbox_size of 10 to purses. See issue #4150.

 

As was just discovered (issue #4573) this prevents a purse in The Creeps from being frobable.

 

The purse isn't frobable because the increased frobbox_size allows the frob controller in the drawer under the purse to think the purse is in the drawer. So when the drawer is closed, the purse is unfrobable.

 

Since the purse has been assigned to the drawer, it isn't assigned to the secret door. When the door is opened, the purse is ignored and it doesn't become frobable.

 

My take on the discussion here is that folks thought it would be nice if purses automatically received a bigger frobbox_size to make it easier for them to be frobbed out of chests.

 

But the bureau is a complex beast full of frob blockers and frob controllers and increasing frobbox sizes amongst that complexity causes problems.

 

 

 

I propose reverting the 2.05 +10 frobbox_size on purses and going back to "it's up to the mapper to make sure items inside chests and bureaus and desks are frobable", which is how it's been since day 1.

 

Comments?

  • Like 2
Link to comment
Share on other sites

I don't know the specifics, but TDS used frob_bias parameter do sort out what is frobbed in the first place, when you had several objects in a chest or just placed next to each other. Another, a bit more arbitrary solution that comes to my mind is a script that would temporarily disable frob on a container, right after player opens it, until he/she gets all the content, so there's no frob conflict.

  • Like 1
Link to comment
Share on other sites

I don't know the specifics, but TDS used frob_bias parameter do sort out what is frobbed in the first place, when you had several objects in a chest or just placed next to each other. Another, a bit more arbitrary solution that comes to my mind is a script that would temporarily disable frob on a container, right after player opens it, until he/she gets all the content, so there's no frob conflict.

 

Thanks for the suggestion. Players have been complaining about inability to frob things for years, but in most cases these are ironed out during beta testing by adjusting frob_bias and frobbox_size on the problematic items.

 

The issue with making a general change as was made in 2.05 is that mappers who worked around the bug may now be faced with the bug going away, thus wrecking their workaround.

  • Like 1
Link to comment
Share on other sites

Frob bias should do, or maybe making things unfrobabble until the lid is open, which I saw in a few maps already. I also saw cases where you could frob chests in addition to chest lids, and I bet that causes a lot of trouble as well. IMO as a rule of thumb, only lids should be made frobbable.

  • Like 1
Link to comment
Share on other sites

Frob bias should do, or maybe making things unfrobabble until the lid is open, which I saw in a few maps already. I also saw cases where you could frob chests in addition to chest lids, and I bet that causes a lot of trouble as well. IMO as a rule of thumb, only lids should be made frobbable.

 

Again, this can be worked out during beta test. The frob relationship between chests and lids has changed over the years, and I think that the prefabs are now set up properly (or at least they should be).

  • Like 2
Link to comment
Share on other sites

The frob box size change should have been made into a new purse entity like purse_new_frob or something

so that it could be used by mappers going forward.

 

Even smart cookies like SteveL sometimes forget that changes to in-use assets can break maps where said

assets have been tweaked (etc).

 

I hope the SVN issue can be resolved. It would be a shame to lose those new collision optimizations. @stgatilov?

  • Like 1

Please visit TDM's IndieDB site and help promote the mod:

 

http://www.indiedb.com/mods/the-dark-mod

 

(Yeah, shameless promotion... but traffic is traffic folks...)

Link to comment
Share on other sites

It's good to know I wasn't going crazy, I've encountered a couple of completely unfrobable purses, one in A House of Locked Secrets comes to mind. I'm not a fan of piling entities in the browser, it's already super confusing to a newcomer looking at our candle entities, for instance. Right now the bug makes missions not able to be 100% looted, so I'm for reverting the change, SVN issues notwithstanding (dunno what's goin' on there!)

My FMs: The King of Diamonds (2016) | Visit my Mapbook thread sometimes! | Read my tutorial on Image-Based Lighting Workflows for TDM!

 

 

Link to comment
Share on other sites

The purse frobability problem in The Creeps is fixed in the latest SVN (14849).

 

I reverted the frobbox_size change back from 10 to 0 for moveable and non-moveable purses.

 

This allowed me to revert a code change I had made for a similar unfrobable purse problem in Accountant 2.

 

With the code reverted and the frobbox_sizes reverted, both The Creeps and Accountant 2 work correctly.

  • Like 1
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

  • Recent Status Updates

    • OrbWeaver

      Does anyone actually use the Normalise button in the Surface inspector? Even after looking at the code I'm not quite sure what it's for.
      · 7 replies
    • Ansome

      Turns out my 15th anniversary mission idea has already been done once or twice before! I've been beaten to the punch once again, but I suppose that's to be expected when there's over 170 FMs out there, eh? I'm not complaining though, I love learning new tricks and taking inspiration from past FMs. Best of luck on your own fan missions!
      · 4 replies
    • The Black Arrow

      I wanna play Doom 3, but fhDoom has much better features than dhewm3, yet fhDoom is old, outdated and probably not supported. Damn!
      Makes me think that TDM engine for Doom 3 itself would actually be perfect.
      · 6 replies
    • Petike the Taffer

      Maybe a bit of advice ? In the FM series I'm preparing, the two main characters have the given names Toby and Agnes (it's the protagonist and deuteragonist, respectively), I've been toying with the idea of giving them family names as well, since many of the FM series have named protagonists who have surnames. Toby's from a family who were usually farriers, though he eventually wound up working as a cobbler (this serves as a daylight "front" for his night time thieving). Would it make sense if the man's popularly accepted family name was Farrier ? It's an existing, though less common English surname, and it directly refers to the profession practiced by his relatives. Your suggestions ?
      · 9 replies
    • nbohr1more

      Looks like the "Reverse April Fools" releases were too well hidden. Darkfate still hasn't acknowledge all the new releases. Did you play any of the new April Fools missions?
      · 5 replies
×
×
  • Create New...