Jump to content


Photo

Weird compass in SVN


  • Please log in to reply
20 replies to this topic

#1 grayman

grayman

    Master Builder, Coder

  • Active Developer
  • PipPipPipPipPip
  • 12727 posts

Posted 01 October 2018 - 09:37 PM

I haven't updated from SVN (assets/source) in a while, and I recall some mention of this problem in some thread, but I can't find the thread, and I can't find a bug report for the problem.

 

Just noticed this in my WIP.

 

Attached File  compass.jpg   175.34KB   0 downloads

 

'nuff said.



#2 duzenko

duzenko

    Advanced Member

  • Active Developer
  • PipPipPip
  • 1805 posts

Posted 02 October 2018 - 12:21 AM

I will check today

#3 duzenko

duzenko

    Advanced Member

  • Active Developer
  • PipPipPip
  • 1805 posts

Posted 02 October 2018 - 05:04 AM

I haven't updated from SVN (assets/source) in a while, and I recall some mention of this problem in some thread, but I can't find the thread, and I can't find a bug report for the problem.

 

Just noticed this in my WIP.

 

attachicon.gif compass.jpg

 

'nuff said.

I can't repeat that compass background bug. Please attach your .cfg and if easy a test map or a map name where this plays up.

I can see however a compass offset on the screen with r_fboResolution < 0.



#4 grayman

grayman

    Master Builder, Coder

  • Active Developer
  • PipPipPipPipPip
  • 12727 posts

Posted 02 October 2018 - 06:14 AM

I started "A New Job" and the problem was there.

 

Since I'm working on the keyhole addition, I'm building my own binaries, so ...

 

I deleted my binaries.

 

I updated to the current SVN binaries and assets.

 

I started "A New Job" again and the problem was gone.

 

I then updated to the latest source and rebuilt the binaries w/ my keyhole changes.

 

The problem returned.

 

So now I suspect something I'm doing is causing the problem, though I'm not working anywhere in the area of icon presentation or the painting of the compass.

 

I'll post a bugtracker for myself and get back to it when I can.

 

Btw, my r_fboResolution is "1" throughout all this.

 

Thanks.



#5 duzenko

duzenko

    Advanced Member

  • Active Developer
  • PipPipPip
  • 1805 posts

Posted 02 October 2018 - 07:01 AM

I started "A New Job" and the problem was there.

 

Since I'm working on the keyhole addition, I'm building my own binaries, so ...

 

I deleted my binaries.

 

I updated to the current SVN binaries and assets.

 

I started "A New Job" again and the problem was gone.

 

I then updated to the latest source and rebuilt the binaries w/ my keyhole changes.

 

The problem returned.

 

So now I suspect something I'm doing is causing the problem, though I'm not working anywhere in the area of icon presentation or the painting of the compass.

 

 

I'll post a bugtracker for myself and get back to it when I can.

 

Btw, my r_fboResolution is "1" throughout all this.

 

Thanks.

I can't see the weird background there but the compass draws half-shadowed. I suppose that's not good?

Never mind, it's my local changes.

Attached Files



#6 nbohr1more

nbohr1more

    Darkmod PR, Wordsmith

  • Development Role
  • PipPipPipPipPip
  • 9101 posts

Posted 28 November 2018 - 05:32 PM

Copied from the tracker:

I have seen this too.

I believe the problem lies in the fact that the compass is rendered in a
GUI where there is broken stub code for the lighting since the
changes described in 0004569.

In older engine builds, this simply broke the lighting but now all rendering is
predicated on having the correct FBO attributes and the broken stub code is not
generating the source data for the FBO's.


Please visit TDM's IndieDB site and help promote the mod:

http://www.indiedb.c...ds/the-dark-mod

(Yeah, shameless promotion... but traffic is traffic folks...)

#7 duzenko

duzenko

    Advanced Member

  • Active Developer
  • PipPipPip
  • 1805 posts

Posted 29 November 2018 - 12:38 PM

Try now


  • nbohr1more likes this

#8 nbohr1more

nbohr1more

    Darkmod PR, Wordsmith

  • Development Role
  • PipPipPipPipPip
  • 9101 posts

Posted 29 November 2018 - 01:06 PM

Thanks. I'll test tonight! :)
Please visit TDM's IndieDB site and help promote the mod:

http://www.indiedb.c...ds/the-dark-mod

(Yeah, shameless promotion... but traffic is traffic folks...)

#9 grayman

grayman

    Master Builder, Coder

  • Active Developer
  • PipPipPipPipPip
  • 12727 posts

Posted 29 November 2018 - 08:10 PM

Tested. Got the same result in 32- and 64-bit. The initial problem is fixed, but when looking straight down, there's a circular shadow on the compass.

 

Attached File  compass.jpg   302.29KB   0 downloads

 

This is with Soft Shadows on and set to Low.

 

If I turn Soft Shadows off, the circle goes away.

 

 



#10 nbohr1more

nbohr1more

    Darkmod PR, Wordsmith

  • Development Role
  • PipPipPipPipPip
  • 9101 posts

Posted 29 November 2018 - 09:27 PM

Another issue:

Single pass shadow maps sometimes make the compass render black.

r_shadows 2
r_shadowMapSinglepass 1

Quickest replication:

1) Install mission Closemouthed Shadows
2) After the mission starts open the console and type:

spawn atdm:playertools_compass

3) Cycle Inventory until the Compass appears

With the default r_shadowMapSinglepass enabled, the compass will be black
but moving around will sometimes illuminate it.

Disabling r_shadowMapSinglepass causes it to remain visible with no artifacts
including the issue reported above.
Please visit TDM's IndieDB site and help promote the mod:

http://www.indiedb.c...ds/the-dark-mod

(Yeah, shameless promotion... but traffic is traffic folks...)

#11 duzenko

duzenko

    Advanced Member

  • Active Developer
  • PipPipPip
  • 1805 posts

Posted 30 November 2018 - 11:14 AM

Tested. Got the same result in 32- and 64-bit. The initial problem is fixed, but when looking straight down, there's a circular shadow on the compass.

 

attachicon.gif compass.jpg

 

This is with Soft Shadows on and set to Low.

 

If I turn Soft Shadows off, the circle goes away.

 

 

Umm...

The trivial fix is to add a noshadows flag to the compass light (which is also healthy in the performance aspect).

Committed to svn. Please advise if I went in the wrong direction.



#12 duzenko

duzenko

    Advanced Member

  • Active Developer
  • PipPipPip
  • 1805 posts

Posted 30 November 2018 - 11:25 AM

Another issue:

Single pass shadow maps sometimes make the compass render black.

r_shadows 2
r_shadowMapSinglepass 1

Quickest replication:

1) Install mission Closemouthed Shadows
2) After the mission starts open the console and type:

spawn atdm:playertools_compass

3) Cycle Inventory until the Compass appears

With the default r_shadowMapSinglepass enabled, the compass will be black
but moving around will sometimes illuminate it.

Disabling r_shadowMapSinglepass causes it to remain visible with no artifacts
including the issue reported above.

Sorry, can't repeat

 

Attached File  Untitled.jpg   119.95KB   0 downloads



#13 nbohr1more

nbohr1more

    Darkmod PR, Wordsmith

  • Development Role
  • PipPipPipPipPip
  • 9101 posts

Posted 30 November 2018 - 12:40 PM

Still happening for me.

Also it seems that screenshot caused the shadow to toggle off :(

 

Attached File  closemouthed_shadows_2018-11-30_12.37.58.jpg   98.4KB   0 downloads

 

On the bright side, Stencil Shadow mode is fixed. :)


Please visit TDM's IndieDB site and help promote the mod:

http://www.indiedb.c...ds/the-dark-mod

(Yeah, shameless promotion... but traffic is traffic folks...)

#14 duzenko

duzenko

    Advanced Member

  • Active Developer
  • PipPipPip
  • 1805 posts

Posted 30 November 2018 - 12:48 PM

Still happening for me.

Also it seems that screenshot caused the shadow to toggle off :(

 

attachicon.gif closemouthed_shadows_2018-11-30_12.37.58.jpg

 

On the bright side, Stencil Shadow mode is fixed. :)

What's your SS radius cvar value?



#15 nbohr1more

nbohr1more

    Darkmod PR, Wordsmith

  • Development Role
  • PipPipPipPipPip
  • 9101 posts

Posted 30 November 2018 - 01:02 PM

r_softShadowsRadius -0.65

 

r_softShadowsQuality 24


Please visit TDM's IndieDB site and help promote the mod:

http://www.indiedb.c...ds/the-dark-mod

(Yeah, shameless promotion... but traffic is traffic folks...)

#16 grayman

grayman

    Master Builder, Coder

  • Active Developer
  • PipPipPipPipPip
  • 12727 posts

Posted 30 November 2018 - 04:16 PM

For me, the original problem is fixed, and the secondary problem of seeing the circle on the compass with soft shadows on has also been fixed.

 

Good work, thx!



#17 duzenko

duzenko

    Advanced Member

  • Active Developer
  • PipPipPip
  • 1805 posts

Posted 02 December 2018 - 02:27 AM

r_softShadowsRadius -0.65

 

r_softShadowsQuality 24

I'm afraid we should pause on the single pass shadow maps for now

The GS appears to be too slow for the task.

Our current code does it on the CPU only when interaction is created/changes. It's slow with dynamic interactions, but there are not too many of them.

I hoped the GS could do it in real time but alas it's about 40% slower than using the pre-computed index subsets



#18 duzenko

duzenko

    Advanced Member

  • Active Developer
  • PipPipPip
  • 1805 posts

Posted 02 December 2018 - 06:31 AM

Still happening for me.

Also it seems that screenshot caused the shadow to toggle off :(

 

attachicon.gif closemouthed_shadows_2018-11-30_12.37.58.jpg

 

On the bright side, Stencil Shadow mode is fixed. :)

Try now

 

I don't know why it was only the single pass broken but there was a bigger problem of duplicate/unnecessary views generated by the frontend


  • nbohr1more likes this

#19 nbohr1more

nbohr1more

    Darkmod PR, Wordsmith

  • Development Role
  • PipPipPipPipPip
  • 9101 posts

Posted 02 December 2018 - 08:36 PM

Still not quite cured...

 

Same Closemouthed Shadows replication except the compass renders correctly until

you enter the room with the fireplace where the compass turns black.


  • duzenko likes this
Please visit TDM's IndieDB site and help promote the mod:

http://www.indiedb.c...ds/the-dark-mod

(Yeah, shameless promotion... but traffic is traffic folks...)

#20 duzenko

duzenko

    Advanced Member

  • Active Developer
  • PipPipPip
  • 1805 posts

Posted 04 December 2018 - 11:42 AM

Still not quite cured...

 

Same Closemouthed Shadows replication except the compass renders correctly until

you enter the room with the fireplace where the compass turns black.

Please test



#21 nbohr1more

nbohr1more

    Darkmod PR, Wordsmith

  • Development Role
  • PipPipPipPipPip
  • 9101 posts

Posted 04 December 2018 - 11:37 PM

ALL FIXED!!! (Finally :) )


Please visit TDM's IndieDB site and help promote the mod:

http://www.indiedb.c...ds/the-dark-mod

(Yeah, shameless promotion... but traffic is traffic folks...)




0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users