Jump to content
The Dark Mod Forums

Segfault When Activating "show All Light Volumes" With A Selected Light With Light_center [closed]

OrbWeaver
 Share

Recommended Posts

OrbWeaver

OrbWeaver

Posted
Posted

Steps to recreate:

 

1. Create a light

2. Give the light a light_center and move it so you can see it

3. Select the light

4. Activate "Show all light volumes"

5. Crash.

 

The segfault seems to originate in the RenderLightRadiiBox::render() method, possibly some incorrect array data is being passed to OpenGL.

DarkRadiant homepage ⋄ DarkRadiant user guide ⋄ OrbWeaver's Dark Ambients ⋄ Blender export scripts

Link to comment
Share on other sites
greebo

greebo

Posted
Posted

This may be connected with these deprecated vector3 functions I removed in one of the last commits. I'm at work, so I cannot do anything till the evening, I hope this is soon enough. Would I need a debugger to investigate this?

 

Is the light_center necessary? Ordinary lights "without" center are fine?

Link to comment
Share on other sites
OrbWeaver

OrbWeaver

Posted
  • Author
Posted
This may be connected with these deprecated vector3 functions I removed in one of the last commits. I'm at work, so I cannot do anything till the evening, I hope this is soon enough. Would I need a debugger to investigate this?

 

You would probably need a debugger yes, for segfaults you really need a back trace. I can continue to investigate it, I just posted here to keep track of the problem.

 

Is the light_center necessary? Ordinary lights "without" center are fine?

 

That does seem to be the case, yes. I tried several times with a non-center light, and couldn't get it to crash (besides, if selecting ANY light in show-all-radius mode caused a crash it would have been picked up before now).

DarkRadiant homepage ⋄ DarkRadiant user guide ⋄ OrbWeaver's Dark Ambients ⋄ Blender export scripts

Link to comment
Share on other sites
greebo

greebo

Posted
Posted
You would probably need a debugger yes, for segfaults you really need a back trace. I can continue to investigate it, I just posted here to keep track of the problem.

Having to use a debugger is a problem for me as I couldn't get gdb to work in Windows and my Linux is a little screwed at the moment. So I'm probably not much of a help for you here, I'm afraid.

That does seem to be the case, yes. I tried several times with a non-center light, and couldn't get it to crash (besides, if selecting ANY light in show-all-radius mode caused a crash it would have been picked up before now).

Well yes, I can imagine that, but you never know...

Link to comment
Share on other sites
OrbWeaver

OrbWeaver

Posted
  • Author
Posted

FIXED. A simple reordering of Light::renderSolid() solved the problem, for some reason the light center render code was messing up the renderer state so that the radius could no longer be drawn (I haven't bothered to investigate in detail since it would require understanding the convoluted renderer code better than I do).

DarkRadiant homepage ⋄ DarkRadiant user guide ⋄ OrbWeaver's Dark Ambients ⋄ Blender export scripts

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

  • Recent Status Updates

    • taffernicus

      taffernicus

      i am so euphoric to see new FMs keep coming out and I am keen to try it out in my leisure time, then suddenly my PC is spouting a couple of S.M.A.R.T errors...
      tbf i cannot afford myself to miss my network emulator image file&progress, important ebooks, hyper-v checkpoint & hyper-v export and the precious thief & TDM gamesaves. Don't fall yourself into & lay your hands on crappy SSD
       
      · 2 replies
    • OrbWeaver

      OrbWeaver

      Does anyone actually use the Normalise button in the Surface inspector? Even after looking at the code I'm not quite sure what it's for.
      · 7 replies
    • Ansome

      Ansome

      Turns out my 15th anniversary mission idea has already been done once or twice before! I've been beaten to the punch once again, but I suppose that's to be expected when there's over 170 FMs out there, eh? I'm not complaining though, I love learning new tricks and taking inspiration from past FMs. Best of luck on your own fan missions!
      · 4 replies
    • The Black Arrow

      The Black Arrow

      I wanna play Doom 3, but fhDoom has much better features than dhewm3, yet fhDoom is old, outdated and probably not supported. Damn!
      Makes me think that TDM engine for Doom 3 itself would actually be perfect.
      · 6 replies
    • Petike the Taffer

      Petike the Taffer

      Maybe a bit of advice ? In the FM series I'm preparing, the two main characters have the given names Toby and Agnes (it's the protagonist and deuteragonist, respectively), I've been toying with the idea of giving them family names as well, since many of the FM series have named protagonists who have surnames. Toby's from a family who were usually farriers, though he eventually wound up working as a cobbler (this serves as a daylight "front" for his night time thieving). Would it make sense if the man's popularly accepted family name was Farrier ? It's an existing, though less common English surname, and it directly refers to the profession practiced by his relatives. Your suggestions ?
      · 9 replies
×
×
  • Create New...