Jump to content
The Dark Mod Forums

I'd like to contribute my HDR implementation

J.C.Denton

By J.C.Denton
in I want to Help

 Share

Recommended Posts

AluminumHaste

AluminumHaste

Posted
Posted

Hmmm some interesting results running the water_murk and water_murk2 maps. None of the water in those maps causes the slow FPS issue. Here's the console dump.

 

water_murk.map

Entered water with murkiness 0.100000.
UNDERWATER: After water check overlay is guis/underwater/underwater_green_thin
murk.gui
Leaving water. 
Entered water with murkiness 0.600000.
UNDERWATER: After water check overlay is guis/underwater/water_dark.gui
Leaving water.
Entered water with murkiness 0.200000.
UNDERWATER: After water check overlay is guis/underwater/water_sea_01.gui
Leaving water.
Entered water with murkiness 0.100000.
UNDERWATER: After water check overlay is guis\underwater\underwater_green_thin
murk.gui
Leaving water.
Entered water with murkiness 0.100000.
UNDERWATER: After water check overlay is guis/underwater/water_green.gui
Leaving water.
Entered water with murkiness 0.100000.
UNDERWATER: After water check overlay is guis/underwater/water_green.gui
Leaving water.
Entered water with murkiness 0.100000.
UNDERWATER: After water check overlay is guis/underwater/underwater_green_thin
murk.gui
Leaving water.
Entered water with murkiness 0.100000.
UNDERWATER: After water check overlay is guis/underwater/water_green.gui
Leaving water.

 

water_murk2.map

 

Entered water with murkiness 0.100000.
UNDERWATER: After water check overlay is guis\underwater\underwater_bluegrey_m
idmurk.gui
Leaving water.
Entered water with murkiness 0.100000.
UNDERWATER: After water check overlay is guis\underwater\underwater_green_thin
murk.gui
Leaving water.
Entered water with murkiness 0.100000.
UNDERWATER: After water check overlay is guis\underwater\underwater_green_midm
urk.gui
Leaving water.
Entered water with murkiness 0.100000.
UNDERWATER: After water check overlay is guis\underwater\underwater_green_thic
kmurk.gui
Leaving water.
Entered water with murkiness 0.100000.
UNDERWATER: After water check overlay is guis\underwater\underwater_green_thic
kmurk.gui
Leaving water.
Entered water with murkiness 0.100000.
UNDERWATER: After water check overlay is guis\underwater\underwater_greengrey_
thinmurk.gui
Leaving water.
Entered water with murkiness 0.100000.
UNDERWATER: After water check overlay is guis\underwater\underwater_greengrey_
midmurk.gui
Leaving water.
Entered water with murkiness 0.100000.
UNDERWATER: After water check overlay is guis\underwater\underwater_greengrey_
thickmurk.gui
Leaving water.
Entered water with murkiness 0.100000.
UNDERWATER: After water check overlay is guis\underwater\underwater_greengrey_
midmurk.gui
Leaving water.
Entered water with murkiness 0.100000.
UNDERWATER: After water check overlay is guis\underwater\underwater_blue_thinm
urk.gui
Leaving water.
Entered water with murkiness 0.100000.
UNDERWATER: After water check overlay is guis\underwater\underwater_blue_midmu
rk.gui
UNDERWATER: After water check overlay is guis\underwater\underwater_blue_midmu
rk.gui
UNDERWATER: After water check overlay is guis\underwater\underwater_blue_midmu
rk.gui
Leaving water.
Entered water with murkiness 0.100000.
UNDERWATER: After water check overlay is guis\underwater\underwater_blue_thick
murk.gui
Leaving water.
Entered water with murkiness 0.100000.
UNDERWATER: After water check overlay is guis\underwater\underwater_blue_midmu
rk.gui
Leaving water.
Entered water with murkiness 0.100000.
UNDERWATER: After water check overlay is guis\underwater\underwater_bluegrey_t
hinmurk.gui
Leaving water.
Entered water with murkiness 0.100000.
UNDERWATER: After water check overlay is guis\underwater\underwater_bluegrey_m
idmurk.gui
Leaving water.
Entered water with murkiness 0.100000.
UNDERWATER: After water check overlay is guis\underwater\underwater_bluegrey_t
hickmurk.gui
Leaving water.

 

Here are the settings I'm using:

 

r_postprocess_bloomIntensity = "0"

r_postprocess = "1"

r_postprocess_bloomKernelSize = "2"

r_postprocess_sceneGamma = "0.92"

r_postprocess_sceneExposure = "0.9"

r_postprocess_desaturation = "0.05"

r_postprocess_colorCorrectBias = "0.1"

r_postprocess_colorCorrection = "1.15"

r_postprocess_colorCurveBias = "0.54"

r_postprocess_brightPassOffset = ".8"

r_postprocess_brightPassThreshold = "0.4"

r_postprocess_debugMode = "0"

 

At this point I'm all "WTF?" so I loaded up my noblecave map where I'm having this issue.

 

Entered water with murkiness 0.000000.
UNDERWATER: After water check overlay is guis\underwater\underwater_green_thin
murk.gui

 

And again FPS drops to less than 10. The only difference I see is that on my map the murkiness is 0.000000, while all other water is over that.

I always assumed I'd taste like boot leather.

 

Link to comment
Share on other sites
  • Replies 80
  • Created
  • Last Reply

Top Posters In This Topic

Popular Days

Top Posters In This Topic

Popular Days

Popular Posts

J.C.Denton
J.C.Denton

Hi,   I am the same guy who had done Denton's Enhanced Doom 3 mod, from which the bloom effect is now being used in The Dark Mod. I'd like to integrate my latest implementation of HDR with TDM. You c

Posted Images

AluminumHaste

AluminumHaste

Posted
Posted

Okay I thought I had found an issue, looks like when I created the map I used the wrong entity, I was using func/func_liquid, so I changed them all to Liquids\atdm:liquid_water, but same issue. Could be an issue with the map then.

I always assumed I'd taste like boot leather.

 

Link to comment
Share on other sites
  • 2 weeks later...
lukeman3000

lukeman3000

Posted
Posted

Just from experience with sikkpin's HDR mod, the actual HDR portion has a near negligible effect on fps, while the thing that makes it tank the most are softshadows. I haven't had any experience with Denton's HDR mod but if it's anything like sikkpin's then performance shouldn't be an issue.

 

The only thing I would say is that I hope you make high performance an option for people who CAN support it. I mean, I know now everyone has a killer pc, but I think it'd be nice if performance-killing options were at least available to those who could handle them. I could tell that TDM was way below D3 in terms of graphical fidelity, which I find somewhat strange because if you can run D3, why would TDM be so much less intensive?

Link to comment
Share on other sites
New Horizon

New Horizon

Posted
Posted

Just from experience with sikkpin's HDR mod, the actual HDR portion has a near negligible effect on fps, while the thing that makes it tank the most are softshadows. I haven't had any experience with Denton's HDR mod but if it's anything like sikkpin's then performance shouldn't be an issue.

 

The only thing I would say is that I hope you make high performance an option for people who CAN support it. I mean, I know now everyone has a killer pc, but I think it'd be nice if performance-killing options were at least available to those who could handle them. I could tell that TDM was way below D3 in terms of graphical fidelity, which I find somewhat strange because if you can run D3, why would TDM be so much less intensive?

 

We are no longer using JC's 'full' HRD implementation, but rather what we'll call HDR-Lite. It was scaled back at JC's request due to technical issues that can not be solved in a reasonable way until D3 goes open source.

 

TDM is more performance intensive than D3 due to all the extra things it does to make it a Thief like game. Complex AI, sound prop, navigation, stim / response, ambient lighting...and more. The full HDR made things drop considerably, but performance alone wasn't the deal breaker. There are simply some things that we need to work in TDM that wouldn't have worked with HDR...so, we made a compromise and it's going to look very nice. :) Full HDR can wait another year or two until the source code is released.

Link to comment
Share on other sites
lukeman3000

lukeman3000

Posted
Posted

We are no longer using JC's 'full' HRD implementation, but rather what we'll call HDR-Lite. It was scaled back at JC's request due to technical issues that can not be solved in a reasonable way until D3 goes open source.

 

TDM is more performance intensive than D3 due to all the extra things it does to make it a Thief like game. Complex AI, sound prop, navigation, stim / response, ambient lighting...and more. The full HDR made things drop considerably, but performance alone wasn't the deal breaker. There are simply some things that we need to work in TDM that wouldn't have worked with HDR...so, we made a compromise and it's going to look very nice. :) Full HDR can wait another year or two until the source code is released.

 

Gotcha. Well whatever the case, TDM is pretty awesome. Reminds me a lot of oblivion for some reason. I know that's not what you're going for lol, but I'm just saying there's something about it that really reminds me of that game. Definitely a lot of fun.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

  • Recent Status Updates

    • OrbWeaver

      OrbWeaver

      Does anyone actually use the Normalise button in the Surface inspector? Even after looking at the code I'm not quite sure what it's for.
      · 4 replies
    • Ansome

      Ansome

      Turns out my 15th anniversary mission idea has already been done once or twice before! I've been beaten to the punch once again, but I suppose that's to be expected when there's over 170 FMs out there, eh? I'm not complaining though, I love learning new tricks and taking inspiration from past FMs. Best of luck on your own fan missions!
      · 4 replies
    • The Black Arrow

      The Black Arrow

      I wanna play Doom 3, but fhDoom has much better features than dhewm3, yet fhDoom is old, outdated and probably not supported. Damn!
      Makes me think that TDM engine for Doom 3 itself would actually be perfect.
      · 6 replies
    • Petike the Taffer

      Petike the Taffer

      Maybe a bit of advice ? In the FM series I'm preparing, the two main characters have the given names Toby and Agnes (it's the protagonist and deuteragonist, respectively), I've been toying with the idea of giving them family names as well, since many of the FM series have named protagonists who have surnames. Toby's from a family who were usually farriers, though he eventually wound up working as a cobbler (this serves as a daylight "front" for his night time thieving). Would it make sense if the man's popularly accepted family name was Farrier ? It's an existing, though less common English surname, and it directly refers to the profession practiced by his relatives. Your suggestions ?
      · 9 replies
    • nbohr1more

      nbohr1more

      Looks like the "Reverse April Fools" releases were too well hidden. Darkfate still hasn't acknowledge all the new releases. Did you play any of the new April Fools missions?
      · 5 replies
×
×
  • Create New...