compile error in patch/algorithm/General.cpp

[7318 14]

I couldn't complete the compiling, I got the following error:

Quote

patch/algorithm/General.cpp: In function ‘void patch::algorithm::weldPatchPool()’:
patch/algorithm/General.cpp:379:10: error: ‘map’ is not a member of ‘std’
  379 |     std::map<scene::INodePtr, std::vector<PatchNodePtr>> patchesByEntity;
      |          ^~~
patch/algorithm/General.cpp:17:1: note: ‘std::map’ is defined in header ‘<map>’; did you forget to ‘#include <map>’?
   16 | #include "patch/PatchIterators.h"
  +++ |+#include <map>
   17 |
patch/algorithm/General.cpp:379:29: error: expected primary-expression before ‘,’ token
  379 |     std::map<scene::INodePtr, std::vector<PatchNodePtr>> patchesByEntity;
      |                             ^
patch/algorithm/General.cpp:379:55: error: expected primary-expression before ‘>’ token
  379 |     std::map<scene::INodePtr, std::vector<PatchNodePtr>> patchesByEntity;
      |                                                       ^~
patch/algorithm/General.cpp:379:58: error: ‘patchesByEntity’ was not declared in this scope
  379 |     std::map<scene::INodePtr, std::vector<PatchNodePtr>> patchesByEntity;
      |                                                          ^~~~~~~~~~~~~~~
  CXX      rendersystem/backend/glprogram/libradiantcore_la-GenericVFPProgram.lo
  CXX      rendersystem/backend/glprogram/libradiantcore_la-GLSLBumpProgram.lo
  CXX      rendersystem/backend/glprogram/libradiantcore_la-GLSLDepthFillProgram.lo
make[2]: *** [Makefile:4200: patch/algorithm/libradiantcore_la-General.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/home/biel/code/doom/doom3/DarkRadiant/radiantcore'
make[1]: *** [Makefile:753: all-recursive] Error 1
make[1]: Leaving directory '/home/biel/code/doom/doom3/DarkRadiant'
make: *** [Makefile:494: all] Error 2

 

[greebo 34]

I think that's already fixed in orbweaver's branch, I'm going to merge it.

@OrbWeaverThe automake system is officially gone now, isn't it? If so, a few build instructions on the wiki will need an update.

[OrbWeaver 618]

5 hours ago, greebo said:

@OrbWeaverThe automake system is officially gone now, isn't it? If so, a few build instructions on the wiki will need an update.

Indeed it has. I've updated the README.md in the source tree but not the wiki.

[greebo 34]

Ok, great! I'll take a look then

[7318 14]

solved

excellent decision to go with cmake, I could compile without problems, before I installed the new version I had to deinstall the last version to avoid problems thou.