Engine fails to compile from latest SVN

[MirceaKitsune]

Trying to compile the engine from SVN again on Manjaro Linux (KDE Plasma): I did a svn update, generated a fresh build config with cmake without issue. Yet when I run make the console is spammed with lines of messages mixed with weird symbols for a minute, after which I'm given a fail message.

I managed to attached a log of it: Had to compress it to get it down to 1 MB, the output is literally 100 MB large. This link should work, let me know if you can't see it.

https://cdn.discordapp.com/attachments/323539482605387787/893221858382594078/make.tar.gz

[  0%] Copying header
[  0%] Precompiling header
In file included from /home/mircea/Games/Quake/TheDarkMod/engine_SVN/build/TheDarkMod_pch/precompiled.h:99:

<thousands of lines of code madness here>

make[2]: *** [CMakeFiles/TheDarkMod.dir/build.make:80: TheDarkMod_pch/precompiled.h.gch] Error 1
make[1]: *** [CMakeFiles/Makefile2:82: CMakeFiles/TheDarkMod.dir/all] Error 2
make: *** [Makefile:91: all] Error 2

 

Edited October 1, 2021 by MirceaKitsune

[stgatilov]

Look at the file it points to.

For some reason, header files contains trash.
More precisely, it contains object files --- no idea how you got object files in header files.

 

[stgatilov]

By the way, which version of GCC, CMake and make do you use?

[MirceaKitsune]

gcc 11.1.0-1, make 4.3-3, cmake 3.21.3-1. To be extra sure I don't have any files from the past breaking it, I did a "svn cleanup . --remove-unversioned" and "svn cleanup . --remove-ignored" which also removed the build directory entirely, and of course "svn update" is up to date with the repo: Still the exact same thing.

Edited October 1, 2021 by MirceaKitsune

[stgatilov]

You should also do svn revert, then look at some of the headers from the error message, and verify that it contains text. Than start build. Then look at the header again: does it still contain text?

[stgatilov]

You can also try to comment out the following lines in CMakeLists.txt:

add_precompiled_header(TheDarkMod
		"idlib/precompiled.h" "idlib/precompiled.cpp" "precompiled.h"
		EXCLUDE "game/gamesys/TypeInfo.cpp" "idlib/Token.cpp" "idlib/bv/Frustum_gcc.cpp" "sys/win32/rc/CreateResourceIDs.cpp" "ThirdParty/artefacts/tracy/src/TracyClient.cpp"
)

Just put # (sharp) at the beginning of every line.

Perhaps it would change something...

[MirceaKitsune]

I just commented out the lines you suggested in CMakeLists.txt and redid the cmake setup: Same issue.

Yet I managed to fix it: Doing a fresh SVN clone resolved this problem. I have no idea what could have gotten stuck in the old one... even after a fresh build directory, no errors from SVN itself, and two different SVN reset commands.

Compilation now works up to 77% after which it fails with a standard compile error. To avoid making a new thread I'll just share it here, something in the engine code is unhappy with my compiler or OS libraries I take it?

[ 77%] Building CXX object CMakeFiles/TheDarkMod.dir/game/physics/Physics_Player.cpp.o
In file included from /home/mircea/Games/Quake/TheDarkMod/engine_SVN/idlib/../game/Game_local.h:1248,
                 from /home/mircea/Games/Quake/TheDarkMod/engine_SVN/build/TheDarkMod_pch/precompiled.h:105:
/home/mircea/Games/Quake/TheDarkMod/engine_SVN/idlib/../game/physics/Physics_Player.h: In constructor ‘idPhysics_Player::idPhysics_Player()’:
/home/mircea/Games/Quake/TheDarkMod/engine_SVN/idlib/../game/physics/Physics_Player.h:980:49: warning: ‘idPhysics_Player::m_bMidAir’ will be initialized after [-Wreorder]
  980 |         bool                                    m_bMidAir;
      |                                                 ^~~~~~~~~
/home/mircea/Games/Quake/TheDarkMod/engine_SVN/idlib/../game/physics/Physics_Player.h:975:49: warning:   ‘float idPhysics_Player::m_fPrevShoulderingPitchOffset’ [-Wreorder]
  975 |         float                                   m_fPrevShoulderingPitchOffset;
      |                                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/mircea/Games/Quake/TheDarkMod/engine_SVN/game/physics/Physics_Player.cpp:3021:1: warning:   when initialized here [-Wreorder]
 3021 | idPhysics_Player::idPhysics_Player( void )
      | ^~~~~~~~~~~~~~~~
In file included from /home/mircea/Games/Quake/TheDarkMod/engine_SVN/idlib/../game/Game_local.h:1248,
                 from /home/mircea/Games/Quake/TheDarkMod/engine_SVN/build/TheDarkMod_pch/precompiled.h:105:
/home/mircea/Games/Quake/TheDarkMod/engine_SVN/idlib/../game/physics/Physics_Player.h:977:49: warning: ‘idPhysics_Player::m_ShoulderingStartPos’ will be initialized after [-Wreorder]
  977 |         idVec3                                  m_ShoulderingStartPos;
      |                                                 ^~~~~~~~~~~~~~~~~~~~~
In file included from /home/mircea/Games/Quake/TheDarkMod/engine_SVN/idlib/../game/Game_local.h:1248,
                 from /home/mircea/Games/Quake/TheDarkMod/engine_SVN/build/TheDarkMod_pch/precompiled.h:105:
/home/mircea/Games/Quake/TheDarkMod/engine_SVN/idlib/../game/physics/Physics_Player.h:273:49: warning:   ‘float idPhysics_Player::m_fSwimTimeStart_s’ [-Wreorder]
  273 |         float                                   m_fSwimTimeStart_s;
      |                                                 ^~~~~~~~~~~~~~~~~~
/home/mircea/Games/Quake/TheDarkMod/engine_SVN/game/physics/Physics_Player.cpp:3021:1: warning:   when initialized here [-Wreorder]
 3021 | idPhysics_Player::idPhysics_Player( void )
      | ^~~~~~~~~~~~~~~~
In file included from /home/mircea/Games/Quake/TheDarkMod/engine_SVN/idlib/../game/Game_local.h:1248,
                 from /home/mircea/Games/Quake/TheDarkMod/engine_SVN/build/TheDarkMod_pch/precompiled.h:105:
/home/mircea/Games/Quake/TheDarkMod/engine_SVN/idlib/../game/physics/Physics_Player.h:278:49: warning: ‘idPhysics_Player::m_fSwimSpeedModCompensation’ will be initialized after [-Wreorder]
  278 |         float                                   m_fSwimSpeedModCompensation;
      |                                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/mircea/Games/Quake/TheDarkMod/engine_SVN/idlib/../game/physics/Physics_Player.h:274:49: warning:   ‘bool idPhysics_Player::m_bSwimSoundStarted’ [-Wreorder]
  274 |         bool                                    m_bSwimSoundStarted;
      |                                                 ^~~~~~~~~~~~~~~~~~~
/home/mircea/Games/Quake/TheDarkMod/engine_SVN/game/physics/Physics_Player.cpp:3021:1: warning:   when initialized here [-Wreorder]
 3021 | idPhysics_Player::idPhysics_Player( void )
      | ^~~~~~~~~~~~~~~~
/home/mircea/Games/Quake/TheDarkMod/engine_SVN/game/physics/Physics_Player.cpp: In member function ‘void idPhysics_Player::PerformMantle()’:
/home/mircea/Games/Quake/TheDarkMod/engine_SVN/game/physics/Physics_Player.cpp:5099:50: error: ‘numeric_limits’ is not a member of ‘std’
 5099 |                         float floorHeight = std::numeric_limits<float>::lowest();
      |                                                  ^~~~~~~~~~~~~~
/home/mircea/Games/Quake/TheDarkMod/engine_SVN/game/physics/Physics_Player.cpp:5099:65: error: expected primary-expression before ‘float’
 5099 |                         float floorHeight = std::numeric_limits<float>::lowest();
      |                                                                 ^~~~~
make[2]: *** [CMakeFiles/TheDarkMod.dir/build.make:5856: CMakeFiles/TheDarkMod.dir/game/physics/Physics_Player.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:83: CMakeFiles/TheDarkMod.dir/all] Error 2
make: *** [Makefile:91: all] Error 2

[duzenko]

@MirceaKitsune

I just tried on Ubuntu 20 WSL and it builds

Note my gcc version on the screenshot

Spoiler

Your options: downgrade your gcc, create a bugtracker issue for this, try the C++ include below

@stgatilov

 #include <limits>

?

[stgatilov]

Yeah, #include <limits> is needed at the beginning of the cpp file.

[stgatilov]

13 hours ago, MirceaKitsune said:

Compilation now works up to 77% after which it fails with a standard compile error. To avoid making a new thread I'll just share it here, something in the engine code is unhappy with my compiler or OS libraries I take it?

I fixed that.
Please update from SVN and try again.

[MirceaKitsune]

Compiles successfully now! Thank you for the help.