Jump to content
The Dark Mod Forums

Footstep sound bug in version 2.10


Gadavre
 Share

Recommended Posts

Hello dear developers! I tested version 2.10 and noticed a performance improvement over version 2.09. This pleases us! But I also noticed a bug with the sound... The player, when walking to the left (button A), the volume of the sound of his steps goes down. In some missions even this sound is inaudible...
Please, if possible, make the volume of the step sounds the same for all four directions for realism.
 


I ask you, if possible, to make a fix to version 2.10, as it is a very long time to wait for the release of version 2.11

 

Edited by Gadavre
  • Like 3
Link to comment
Share on other sites

I can confirm this, on Linux anyway. Walking left, you make the same footstep sounds as crouching and creeping forwards.

Edited by thebigh
  • Like 1

{ 0 | 🞵 } = funk_tastic

My missions:           Stand-alone                                                      Duncan Lynch series                              

                                      Down and Out on Newford Road              the Factory Heist

                                                                                                  A House Call

                              

Link to comment
Share on other sites

Confirmed in Windows. Only when sidestepping left. That's rather strange.

  • Like 2

A word of warning, Agent Denton. This was a simulated experience; real LAMs will not be so forgiving.

Link to comment
Share on other sites

I could be wrong because it was a fast look at the code but based on my debug section of the Move code, the problem seems to be that, when the player steeps to the left the "moveType" string, is set to "creep" and when moving right, is set to "walk", that causes different sound volumes to be set for the final steep sound. 

Link to comment
Share on other sites

I think I found the real problem

on the player cpp file on UpdateConditions() function

this code 

// DarkMod: Catch the creep modifier
...
	else {
		int creepLimit = cv_pm_creepmod.GetFloat() * 127;
		AI_CREEP = (usercmd.buttons & BUTTON_CREEP) ||
			(idMath::Abs(usercmd.forwardmove) <= creepLimit && idMath::Abs(usercmd.rightmove <= creepLimit));
	}

 

Needs to be like this

// DarkMod: Catch the creep modifier
...
	else {
		int creepLimit = cv_pm_creepmod.GetFloat() * 127;
		AI_CREEP = (usercmd.buttons & BUTTON_CREEP) |
			(idMath::Abs(usercmd.forwardmove) <= creepLimit && idMath::Abs(usercmd.rightmove) <= creepLimit);
	}

 

The close ) for the idMath::Abs was on the wrong place.

The change to bitwise OR |  instead of the logic OR || was a recommendation of visual studio 2022, not something I really know if necessary, changing that didn't solved the bug nor the behavior, a better programmer may explain why VS recommended that change.

  • Like 4
Link to comment
Share on other sites

Posted (edited)
1 hour ago, HMart said:

on the player cpp file on UpdateConditions() function

I don't understand. Where can I find player cpp file ? Please give me the path to this file and I'll fix it myself.

Edited by Gadavre
Link to comment
Share on other sites

I'm talking about the engine and game source code, the c++ source code. 

Unfortunately, unless you know how to code in c++ and how to compile the engine than you will have to wait for the TDM team to solve that bug.

The best way is to make a bug report and link this thread there.

Link to comment
Share on other sites

Posted (edited)
8 minutes ago, HMart said:

The best way is to make a bug report and link this thread there.

Where do I write  a bug report? What topic?

 

Edited by Gadavre
Link to comment
Share on other sites

Posted (edited)

HMart

I tested the old version 2.07, it doesn't have this bug...   For some reason, creating new versions of the game leads to new bugs.
I already thought about trying to transfer all the new textures, models, scripts and sounds from the new version 2.10 to the old version 2.07. But I'm not a programmer, it's very complicated.

Edited by Gadavre
  • Haha 2
Link to comment
Share on other sites

7 minutes ago, Gadavre said:

HMart

... For some reason, creating new versions of the game leads to new bugs. ...

haha yes that is true, is a fact of game development, is because people are writing new code, copying or moving code around and sometimes simple mistakes are made, in code, even a simple comma in the wrong place, can break a entire game. And even code that worked fine before, after some new work can stop working for some obscure reason, is called regressions, 3 steeps forward, 1 steep backward. :)

Have patience and just wait, I'm sure that when someone in the team sees this, they will solve it and maybe, make a patch or solve it for the next TDM version but only them can decided that. 

Link to comment
Share on other sites

58 minutes ago, HMart said:

3 steeps forward, 1 steep backward.

Some of which make a creep sound, other normal footstep sounds.

  • Haha 1

{ 0 | 🞵 } = funk_tastic

My missions:           Stand-alone                                                      Duncan Lynch series                              

                                      Down and Out on Newford Road              the Factory Heist

                                                                                                  A House Call

                              

Link to comment
Share on other sites

On 4/16/2022 at 2:36 PM, HMart said:

I think I found the real problem

on the player cpp file on UpdateConditions() function

this code 

// DarkMod: Catch the creep modifier
...
	else {
		int creepLimit = cv_pm_creepmod.GetFloat() * 127;
		AI_CREEP = (usercmd.buttons & BUTTON_CREEP) ||
			(idMath::Abs(usercmd.forwardmove) <= creepLimit && idMath::Abs(usercmd.rightmove <= creepLimit));
	}

 

Needs to be like this

// DarkMod: Catch the creep modifier
...
	else {
		int creepLimit = cv_pm_creepmod.GetFloat() * 127;
		AI_CREEP = (usercmd.buttons & BUTTON_CREEP) |
			(idMath::Abs(usercmd.forwardmove) <= creepLimit && idMath::Abs(usercmd.rightmove) <= creepLimit);
	}

 

The close ) for the idMath::Abs was on the wrong place.

The change to bitwise OR |  instead of the logic OR || was a recommendation of visual studio 2022, not something I really know if necessary, changing that didn't solved the bug nor the behavior, a better programmer may explain why VS recommended that change.

 

Confirmed this code change fixes the issue, and I can't find any bugs that it could possibly introduce, though my testing was limited to just playing the game and trying to break it.

  • Like 3

I always assumed I'd taste like boot leather.

 

Link to comment
Share on other sites

Posted (edited)
On 4/23/2022 at 5:16 PM, AluminumHaste said:

I think I found the real problem

thank you.  Has this already been fixed in the latest dev16485-9903 build?

Edited by Gadavre
Link to comment
Share on other sites

On 4/16/2022 at 8:36 PM, HMart said:

I think I found the real problem

on the player cpp file on UpdateConditions() function

this code 

// DarkMod: Catch the creep modifier
...
	else {
		int creepLimit = cv_pm_creepmod.GetFloat() * 127;
		AI_CREEP = (usercmd.buttons & BUTTON_CREEP) ||
			(idMath::Abs(usercmd.forwardmove) <= creepLimit && idMath::Abs(usercmd.rightmove <= creepLimit));
	}

 

Needs to be like this

// DarkMod: Catch the creep modifier
...
	else {
		int creepLimit = cv_pm_creepmod.GetFloat() * 127;
		AI_CREEP = (usercmd.buttons & BUTTON_CREEP) |
			(idMath::Abs(usercmd.forwardmove) <= creepLimit && idMath::Abs(usercmd.rightmove) <= creepLimit);
	}

 

The close ) for the idMath::Abs was on the wrong place.

The change to bitwise OR |  instead of the logic OR || was a recommendation of visual studio 2022, not something I really know if necessary, changing that didn't solved the bug nor the behavior, a better programmer may explain why VS recommended that change.

VS probably recommended to change to bitwise OR because a bitwise AND was used in the term before that and VS did not understand that what we actually want is a boolean. I bet if you changed it to 

AI_CREEP = (usercmd.buttons & BUTTON_CREEP) != 0 ||
   (idMath::Abs(usercmd.forwardmove) <= creepLimit && idMath::Abs(usercmd.rightmove) <= creepLimit);

, i.e., convert the bitwise AND result directly to bool, VS would not recommend to change the OR operator.

  • Thanks 1
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share

  • Recent Status Updates

    • Nort

      I did it! I finally did it! After 48 hours of frustration and confusion, I managed to finally sort out how to attach equipment to NPC:s properly, and write down coherent instructions on how to do it, both in my manual, and in this forum.
      I can finally rest. I can finally eat breakfast.
      · 0 replies
    • Nort

      Spent most of the day learning and writing about AI navigation. It's stuff I already know, but the magic about writing something down as clearly formulated as possible, is that you then see things that much more clearly. You also find what's unclear to you, and then you figure out exactly how things work. I was hoping to get through it all within just a day, but it looks like this will take tomorrow as well, at this rate. There's also plenty of other nonsense I have to get through as well. Everything's a chore.
      · 0 replies
    • Nort

      I want to be a fish, but I'm not a fish. My mom wants to be a fish too, and so she's killing herself eating plankton and sh***ng blood, and tells me to stop nagging her about taking her medication. I spent several hours today, just lying in bed, having anxiety over just existing, and not being a fish. You fish, you don't know how lucky you are. You can eat all the plankton you want. I tried eating plankton again yesterday, and I just got sick. I hate being a shark.
      · 0 replies
    • Nort

      I just gave myself vertigo. A pleasant kind of vertigo, like the world has been lifted off my shoulders. I'll explain:
      Yesterday I saw to my dismay, that I had made my entire map two - two - units too short on every level - that every set01 piece was sticking 2 units into the ceiling. That's basically 402 brushes that needs to be realigned (minus the ground floor brushes).
      I knew enough about selections to do all of that in a very tense five minutes, and it compiled without leaks. (Thank you so much, Dark Radiant devs, for making an editor with such care for precision that you can align hundreds of brushes perfectly at once (which is not something I can say for Valve's Hammer editor, which has some serious issues on that front, which actually made me just quit it in disgust).) However, the result is that the entire level has now been stretched a barely noticable 2 units, and it will take some getting used to psychologically.
      · 0 replies
    • Nort

      My workflow is basically running from a chain of disasters, eventually trying to seek shelter in former disasters. It's not ideal - it's just my life.
      When I abandoned my first map, it was out of a typical mental breakdown, and so I returned to find a skybox void where the kitchen door should have been (due to a misplaced visportal) and two overlapping brushes Z-fighting on the kitchen floor.
      I've now cleaned up the last bit of mess, by cleanly separating every floor into its own layer. Now I can finally work on each floor in peace.
      ...not that I really needed to. Once you get skilled enough, the orthographic messes, well, I'll let this video speak for itself:
       
      · 1 reply
×
×
  • Create New...