Projectiles sometimes don't hit the player

[joebarnin]

I just submitted a new bug report: https://bugs.thedarkmod.com/view.php?id=6292. In certain specific cases, projectiles don't collide with the player. I've got a test case where a atdm:func_shooter shoots an arrow right at the player, and it goes 'right through' them without damage. It seems to be related to the angle of the projectile (and whether the player is moving or not). This is new to TDM 2.11. It's the cause of the problem that @JavaGod reported playing my mission: 

 

[tapewolf]

Ah, interesting.  I was seeing something similar the other day.  I was replaying Sotha's Thomas Porter series, and on "The Glenham Tower", I noticed that my fire-arrows tended to go through the haunts in the cellar and smack into the wall behind them.

I would assume that this is a related issue.

[joebarnin]

@tapewolf That sure sounds like the same thing. It seems to happen when the projectile an angle close to 0 or 180 (i.e., east/west). It's easy to recreate the problem with a func_shooter, because they are lined up at a specific angle. But I saw it in gameplay too, when testing my mission. I fired a gas arrow and it went right through the guard. Sure enough, I was shooting pretty much along the X-axis (angle 0).

[minimii]

Very interessing.

Espacially with the Gas and fire arrows I had the same in many Missions. But everytime I thought like "nevermind".

Maybye because I never played a Version before 2.11.

But with the comparrision to like Thief it is frustrating to fire arrows and nothing happens. 

It really seems to be a bug.

[HMart]

Just for curiosity, If any of you are running with unlocked frame rate, lock the game to 60fps (or 60hz) and see if the problem goes away?

[minimii]

I play with this Settings

[joebarnin]

13 hours ago, HMart said:

Just for curiosity, If any of you are running with unlocked frame rate, lock the game to 60fps (or 60hz) and see if the problem goes away?

I tried my test case at 60fps: no change, still goes right though me.

[HMart]

Then is something else thanks for the info.  

Edited May 30, 2023 by HMart

[joebarnin]

I spent some time in the Visual Studio debugging this issue and I think I found the problem. Looks like the following line in Bounds.cpp (line 163) is incorrect:

if ( idMath::Fabs( cross.z ) > extents.x * ld.y + extents.y * ld.z ) {

it should read

if ( idMath::Fabs( cross.z ) > extents.x * ld.y + extents.y * ld.x ) {

The only change is the final variable, it should be ld.x, not ld.z.

This problem was introduced in SVN 9993 (July 14, 2022). The code was refactored to make it more readable and faster, but it looks like a simple error was introduced.

I made the fix on my machine and it resolves the problem. I don't want to check in the fix (and I suspect I don't have access to do so), so I'll leave it to others to verify this change. But I do think this is a serious bug fix that needs to go into the next release. In fact I think it should be put out as a patch to DM 2.11, since other others have reported this, and I've seen it playing other DMs. Basically, any projectile fired on the East/West axis will not hit an AI target (it will go right though them).

I'll update the Bug Report with this info.

[snatcher]

I cannot confirm nor deny the issue is solved but I am grateful somebody looked into this.

Thanks, joebarnin.

[wesp5]

I can confirm that this bug just happened to me in the "One bridge too far" beta, so a patch for 2.11 would be great!

[snatcher]

Minute 36:30