Inventory grid Item sorting

[snatcher]

I just picked up a readable and a coin and the inventory is showing me the loot count. What readable did I just pick up?

Whenever you pick up an item it goes to the first position in its group in the inventory. If you want to find the last readable you picked up you just have to cycle through the groups and as soon you reach the Readables group it will be there, in the first position. Neat.

The Inventory grid decides to break this logic and list items in the opposite order, forcing you to put any logic aside and learn how to interact with what essentially is the same thing in two different ways.

- Wait, is the first item listed the last I picked up or the first?

Please help me understand why things are the way they are. In the meantime, the inventory and the inventory grid can have the same item sorting by going to game/Player.cpp and exchanging:

// Reverse order. New items at the end.
CInventoryItemPtr item = category->GetItem((category->GetNumItems() - 1) - j);
// Except for the weapons, where reverse order is unintuitive...
if ( item->GetType() == CInventoryItem::IT_WEAPON )
	item = category->GetItem( j );

For:

CInventoryItemPtr item = category->GetItem( j );

Cheers!

[nbohr1more]

@Durandall I have no idea about why you chose the current design and do not care either way. Does the current sorting have advantages or is it just a personal preference? If the latter, perhaps we should add a cvar to toggle this?

[wesp5]

2 hours ago, snatcher said:

Please help me understand why things are the way they are. In the meantime, the inventory and the inventory grid can have the same item sorting by going to game/Player.cpp and exchanging...

Can we add this to our mod and patch? Also speaking about inventory sorting, I don't like that weapons are listed first and not permanent tools which would make more sense. Any way to change that as well?

Edited June 22 by wesp5

[snatcher]

23 hours ago, wesp5 said:

Can we add this to our mod and patch?

Not as a mod, as we understand mods currently. Distributing a modded executable requires a proper justification: a game-changing change or a set of many minor but relevant changes.

23 hours ago, wesp5 said:

Also speaking about inventory sorting, I don't like that weapons are listed first and not permanent tools which would make more sense.

Please elaborate. Picture it in your head and document the idea. What happens first? What happens next? What happens if?

[wesp5]

59 minutes ago, snatcher said:

Not as a mod, as we understand mods currently. Distributing a modded executable requires a proper justification: a game-changing change or a set of many minor but relevant changes.

Please elaborate. Picture it in your head and document the idea. What happens first? What happens next? What happens if?

As for the cpp file, I feared as much so we need to wait what the core team thinks about your idea. As for the inventory sorting, it seems to be similarily hard-coded, because whatever I do, the weapons are always listed first in the inventory grid. I would like to have the Blow, Whistle and Numbers tools in the first line so people are more aware that they exist :)!

Edited June 23 by wesp5

[snatcher]

21 hours ago, wesp5 said:

[...] we need to wait what the core team thinks [...]

So far no objections. Players may get lucky this time

[nbohr1more]

LOL, many team members and players objected to the inventory grid feature in the first place.

I think most team members are agnostic about any further development on it other than it's visual design.

If players really want something improved about it, I doubt anyone but Durandall would be precious about changing the current design. Most of the core team would rather you become proficient with the classic hot-keys and key-rings.

[wesp5]

Well, to be honest I wasn't really aware that it existed until I fixed something in my patch. I always use the hot keys :)!

Edited August 12 by wesp5

[Durandall]

Don't care. Also, I never added weapons in the grid, so someone already changed that.

[datiswous]

Oh, I think removing the weapons would be good.

Edited November 18 by datiswous

[wesp5]

Maybe there is a variable which determines the sorting? I tried everything in the file but nothing worked.

[snatcher]

On 6/23/2024 at 11:41 PM, wesp5 said:

[...] the weapons are always listed first in the inventory grid. I would like to have [..]

22 hours ago, Durandall said:

[...] I never added weapons in the grid, so someone already changed that.

21 hours ago, datiswous said:

Oh, I think removing the weapons would be good.

Regardless of your personal preferences, and until someone comes up with an alternative, it is sensible to have weapons listed first so that players can tell at a glance what key tools and ammo they have instead of pressing 8 to see if a Noisemaker comes up.

[demagogue]

If I were designing it from the ground up, I'd have a top row of small boxes designated for weapons ordered numerically, actually now that I think about it, with the ability to rearrange objects into those boxes so the designated object pops up when you push 1-9 on the keyboard, Minecraft style.

[snatcher]

Helloooo TDM fans.

Anybody opposed to this change?

Anybody in favor of this change?

[datiswous]

Is there a feature request made on the bugtracker?

[snatcher]

20 hours ago, datiswous said:

Is there a feature request made on the bugtracker?

I don't know.

Nobody cares, anyway.

[demagogue]

He's right though. The first step in any feature request is to make an entry in the bugtracker, so it's in a list, and it gets discussed and developed from there. It just gets buried and forgotten about if it's only in a thread. I was going to do it myself, but it apparently takes some time to dig through the entries even with the filter.

[snatcher]

Sure but let's first collect some feedback and opinions from the community. I might have gotten it wrong after all and members prefer it the way it is.

[datiswous]

I made a feature request in the bugtracker:

https://bugs.thedarkmod.com/view.php?id=6592

 

Feel free to edit the text, maybe I didn't describe it correctly.

It's a feature request, but it could also be seen as a bug that the grid sorting is oposite.

[snatcher]

Thank you.

[nbohr1more]

Avoiding arguements, made it into a cvar:

tdm_invgrid_sortstyle

[snatcher]

Thank you.