Question: HowTo change skybox based on location?

[Bikerdude]

 So I would like to use the call_on entry, call_on_exit method to change skyboxes. I have tried the following, but its causes a crash on map load - 

I have 2x skybox entities 'portalsky_pagan' and 'portalsky_wastlands'

[kingsal]

You can just trigger them like you have but they need to be called as an entity:

string curr_skybox = "sky_city_night"; // whatever your starting skybox entity is called 

void change_skybox(entity zone) /passes the location ent

{

    entity skybox = zone.getEntityKey("skybox");

 

        if (curr_skybox != skybox.getName())

        {

        sys.trigger(skybox);    // just trigger it

        curr_skybox = skybox.getName();

        }

        sys.println(" [SKY] Sky set to " + curr_skybox);

 

}

You don't need a call on exit since this will check to see if there is change. 
Use spawn arg on the location entity :  "skybox" "yourSkyBoxName"

Give this a try and see if it works, might need some tweaking...

 

 

Edited June 5 by kingsal

[Bikerdude]

49 minutes ago, kingsal said:

Give this a try and see if it works, might need some tweaking...

 

Getting an error, 'curr' dosent seem to be a  valid command?

Edited June 5 by Bikerdude

[datiswous]

You can have multiple info_portalsky entities in a map. Triggering one will change the active skybox to that one.

Quote

Specifies location for portal sky. Multiple portalsky locations are supported, with one 'currently active' info_portalSky providing the view for all portal sky brushes. Triggering an info_portalSky will make it 'current', even if it didn't have a 'triggered' flag to start with.

I just quote the entity info on the wiki/DR.

Edited June 5 by datiswous

[Bikerdude]

16 minutes ago, datiswous said:

You can have multiple info_portalsky entities in a map. Triggering one will change the active skybox to that one.

I just quote the entity info on the wiki/DR.

Yep, but it dosent give an example on how to trigger the info_skyportal - https://wiki.thedarkmod.com/index.php?title=Entity_Database

[datiswous]

It's very simple. Just make a trigger and target the specific info_portalsky.

See added testmap. It has a default portalsky and when you touch the box it will change it to a different portalsky.

 

Edit: Ok maybe I didn't read the topic text correctly, sorry. I guess you already know this, but want to do it via script.

testp.map

Edited June 5 by datiswous

[Bikerdude]

A trigger needs the player to pass through that trigger brush, where as if I can get it trigger via the location the player is in, the player can be anywhere inside that location.

Edited June 5 by Bikerdude

[datiswous]

Ok I got it working. See attachments. Ignore the ugly look. When you walk into the small room on the right the sky changes to the one with the moon. When you go back it changes back to the thunder sky.

void skymoon(entity room2)
{
sys.println("script skymoon running..");
sys.trigger( $moon );
}
void skythunder(entity main)
{
sys.println("script skythunder running..");
sys.trigger( $thunder );
}

void main()
{
}

See also: https://wiki.thedarkmod.com/index.php?title=Location_Settings#Example_script_to_turn_entities_on/off_when_player_enters_a_location

testp.map testp.script

Edited June 5 by datiswous

[datiswous]

What is weird is that I found I made a small error, but it still works..

 

void skythunder(entity main)

Should actually be:

void skythunder(entity room2)

I think, because I'm doing a "call_on_exit" for zone room2

 

Edit: I think the script example is for triggering a single entity on and of while in this case you trigger different scripts for entry and exit. 

 

Edited June 5 by datiswous

[Bikerdude]

So I cleaned it up and and made it simpler for new mappers - 

 

skybox.map skybox.script

[Bikerdude]

So added it to my WIP and am having an issue. If I walk into another info_location that dosent need to change the skybox (so a connecting room) the skybox is being changed anyway.

I have removed the call_on_exit from the info_loc in the first location, but the change is still happening - 

[kingsal]

@Bikerdude You forgot  the first part I posted (which defines the string)
EDIT: see below

Edited June 5 by kingsal

[kingsal]

Actually this should be inside a zone wrapper so you can do other things when changing zones (set fog, trigger sounds, ect) 
This will also activate any targets the you have on the location entities. 
The debounce part is important since it will prevent zones from getting triggered too fast and causing errors.

If you do get weirdness like the wrong skybox appears or the location entity triggers its targets twice, let me know. Might need to bring the grace period down from 0.4 - 0.1 or 0.2.


 

string curr_skybox = "portalsky_night"; // <<define starting skybox

 

void change_skybox(entity zone)

{

    entity skybox = zone.getEntityKey("skybox");

 

        if (curr_skybox != skybox.getName())

        {

        sys.trigger(skybox);    

        curr_skybox = skybox.getName();

        }

        sys.println(" [SKY] Sky set to " + curr_skybox);

 

}

 

entity __last_zone = $null_entity;

float  __last_zone_time = -9999;

 

void setZone(entity zone)

{

 

    float now = sys.getTime();

    // Debounce

    if (__last_zone == zone && (now - __last_zone_time) < 0.4) {

        return;

    }

    __last_zone = zone;

    __last_zone_time = now;

 

    // do stuff

 

    if (zone.getEntityKey("skybox") != $null_entity) {

        change_skybox(zone);

    }

 

    // Drive one-shot triggers

    zone.activateTargets($player1);

 

}

skybox_edit.map skybox_edit.script

Edited June 5 by kingsal

[Bikerdude]

So I edited the map/script to match the entity names in my WIP, and now the starting map isnt correct. But if I leave the zone and re-enter is than become correct.

skybox.map skybox.script

Edited June 5 by Bikerdude

[kingsal]

Ah okay..

We need to set "triggered" "1" on those info_portalsky or the engine will just set whatever sky comes last in your map file as the first skybox.  

Also we need to clear curr_skybox = "" to let the location system update it.
This should work now. No need to trigger the skyboxes in the map file or anything like that.

skybox_edit2.scriptskybox_edit2.map