New Toolbar Layout

[greebo]

This is how it looks like at the moment:

 

 

Any suggestions? It's a matter of seconds to edit the user.xml file to change the position of the icons.

[OrbWeaver]

Looks good. You would save a bit of space by removing the separators at the very top/left of each menu bar, but otherwise it is a big improvement a single huge toolbar. Have you tried testing at different screen resolutions (e.g. 800x600)?

 

If the side (Edit) toolbar gets too large, it might have to be divided into 2 columns just like T3Ed.

[greebo]

Ok, will test it at 800x600 (although I believe anyone using this resolution for editing is kind of masochistic) and then commit the changes.

[New Horizon]

Tried out the new toolbar. It looks great! The only problem I have with it, is that it breaks the other layout options. Orb, I know you had mentioned that you didn't want to support the other layout options, but I really think we should..unless it's far too much extra work. Only reason I ask, is that I enjoy using the layout from the first radio button. I just find it far cleaner to be able to grab a window and have the other windows resize automatically.

[OrbWeaver]

Hmm, I can't see the new toolbar. I just get the single one at the top but several of the icons are missing. EDIT: I thought it might require deleting the local user.xml, but I have done this and now I have no toolbars at all.

 

@Greebo - how difficult would it be to support the splitpane layout as New Horizon suggests?

[New Horizon]

Hmm, I can't see the new toolbar. I just get the single one at the top but several of the icons are missing. EDIT: I thought it might require deleting the local user.xml, but I have done this and now I have no toolbars at all.

 

@Greebo - how difficult would it be to support the splitpane layout as New Horizon suggests?

 

This is what is happening when I try to use my usual layout options. The splitpanes cut off the new toolbar and leave a huge grey area above.

 

 

[greebo]

Hmm, I can't see the new toolbar. I just get the single one at the top but several of the icons are missing. EDIT: I thought it might require deleting the local user.xml, but I have done this and now I have no toolbars at all.

 

@Greebo - how difficult would it be to support the splitpane layout as New Horizon suggests?

Shouldn't be too difficult - I will try to do this tomorrow.

 

No toolbars at all? Is there some error message in radiant.log from ToolbarCreator?

[New Horizon]

Thanks Greebo. Truly appreciated!

[greebo]

Committed. All the other three window layouts work as well now. It was just two characters that had to be changed.

[OrbWeaver]

This is the relevant section of my radiant.log. It looks like it is finding all of the toolbars but only instantiating the texture toolbar.

 

ToolbarCreator: Loading toolbar information from registry.
Found toolbar: view
Found toolbar: edit
Found toolbar: texture
ToolbarCreator: Finished loading toolbar information.
ToolbarCreator: Instantiating toolbar: texture

 

EDIT: Never mind, I just update from SVN and now my toolbars are back.

[greebo]

Actually, there should be two such sections in the radiant log, as the toolbars are parsed everytime a ToolbarCreator class is instantiated (which happens twice: once in mainframe.cpp and once in texwindow.cpp).

 

Thinking of this, I should probably change this in the same manner as it's done with the XMLRegistry, as local static instance.

[New Horizon]

Hmmm, I'm getting an error when I try to build the latest source.

 

scons: Reading SConscript files ...

/usr/bin/ld: cannot find -lboost_regex
collect2: ld returned 1 exit status
scons: *** [build/debug/brushexport.so] Error 1
scons: building terminated because of errors.

[OrbWeaver]

$ sudo apt-get install libboost-regex-dev

[New Horizon]

$ sudo apt-get install libboost-regex-dev

 

Was that something new that was added? I didn't install that before and everything worked alright.

 

Builds fine now though, and everything looks/ works great.

[OrbWeaver]

Yes, the new FilterSystem uses regex (committed today).

[New Horizon]

Yes, the new FilterSystem uses regex (committed today).

 

Ahhh, gotcha. Thanks Orb.