Large Maps Do Not Display Properly [closed]

[greebo]

Point me in a direction, it's most probably my EventManager module...

[OrbWeaver]

Actually I think it is my code:

 

Thread [1] (Suspended: Signal 'SIGSEGV' received. Description: Segmentation fault.)	
14 visit() at /DarkRadiant/radiant/ui/einspector/EntityInspector.cpp:469 0x08155e7a	
13 EntityKeyValues::forEachKeyValue() at /DarkRadiant/libs/entitylib.h:693 0xb6201199	
12 ui::EntityInspector::refreshTreeModel() at /DarkRadiant/radiant/ui/einspector/EntityInspector.cpp:477 0x08156f3c	
11 ui::EntityInspector::callbackRedraw() at /DarkRadiant/radiant/ui/einspector/EntityInspector.cpp:243 0x08156fce	
10 Member<ui::EntityInspector, void, &() at /DarkRadiant/libs/generic/functional.h:13 0x0815803b	
9 BindFirstOpaque<Member<ui::EntityInspector, void, &() at /DarkRadiant/libs/generic/callback.h:120 0x08158057	
8 Callback0<void>::operator() at /DarkRadiant/libs/generic/callback.h:282 0x08089d1e	
7 IdleDraw::draw() at /DarkRadiant/libs/gtkutil/idledraw.h:35 0x08089d35	
6 g_child_watch_add()  0xb7e75bf2	
5 g_main_context_dispatch()  0xb7e738d6	
4 g_main_context_check()  0xb7e76996	
3 g_main_loop_run()  0xb7e76cb8	
2 gtk_main()  0xb7b76765	
1 main() at /DarkRadiant/radiant/main.cpp:546 0x08099721

 

I may have made a typo when cleaning up, investigating.

[OrbWeaver]

D'oh, fixed. I changed the Entity::Visitor interface to std::string rather than const char*, then forgot that the compiler would not complain if those strings were passed directly to gtk functions which in fact expect a const char* in this situation.

[greebo]

Phew, I'm glad it was just that. For a moment I thought I've messed up something again. Recompiling now...

[OrbWeaver]

I noticed a couple of problems with the Skin Chooser that need fixing:

 

1. On Windows the dialog widget displays too low, with the buttons not visible. I have fixed this by making it appear centered on screen rather than over the entity inspector window.

2. There is a segfault on shutdown after the Skin Chooser has been used, owing to the attempt to delete the preview model which in turn releases the shader after the GlobalShaderCache has already been destructed. I will have to investigate the best way to solve this.

 

EDIT: Whoops, there's another one as well. The window does not correctly handle the "window close" event when the upper-right close box is clicked, and cannot be re-shown afterwards.

[OrbWeaver]

The Skin Chooser problems are fixed, but I notice now that the Lighting mode render in Windows does not work. Does it work on Windows for you? I just get a completely black screen, even in a simple map I create myself with just a brush and a light.

 

EDIT: Same behaviour in Linux too.

[greebo]

Could this be related to the shader normal map stuff you changed recently?

[OrbWeaver]

That's a good point, I'll look into it. The new parsing code should return an image map, but it might not be returning anything sensible.

 

Incidentally, I have added a page on the Wiki to cover the pre-release tests for DarkRadiant releases, so that we can be sure that future releases do not introduce glaring bugs that we have forgotten to test. Feel free to add anything you may think of that needs testing, the idea is to have an evolving list of tests which cover all major aspects of DR's functionality.

[greebo]

BTW, I think we can change the thread title to [closed].

[OrbWeaver]

It already says closed - did a moderator change it since you posted that last message?

[greebo]

??? Maybe. Or it possibly was the CIA.