Any way to change leaning to hold (instead of toggle)?

[Komag]

Right now leaning is a toggle, left, right, and forward all stick in the lean. Is this in purpose? I definitely don't like it and want to just lean while holding the key. Is this something we can choose or change in an ini? I couldn't find anything about it

[Ishtvan]

It used to be that way, but it never got updated when the new button handler was put into place. It's on the TODO list.

[Nyarlathotep]

New button-handler? Do you mean KeyState() in Common.h, or a named pipe like we're using for the lightgem?

[Ishtvan]

Yeah, I mean KeyState. Before D3 patch 1.31, that didn't exist, so we were using our own keyboard hook. The hold-button-to-lean code was written for that old keyboard-hook, but never got updated when the patch came out and we got rid of it.

[Nyarlathotep]

Ah. Could you point out (approximately) where it is in the code? I can probably fix it myself, although there may be some problems getting the lean-code to handle non-ASCII inputs.

[Fidcal]

This was discussed HERE. I think I favour the hold and release too as it does seem odd to lock into a lean (though handy at times!)

[Nyarlathotep]

Ah. Could you point out (approximately) where it is in the code? I can probably fix it myself, although there may be some problems getting the lean-code to handle non-ASCII inputs.

I should point out that the supposed problem here is entirely dependent on not being able to read Doom 3's impulses--which is exactly what ButtonState() does. Please forgive me for my momentary lapse in intelligence. I bloody well should have remembered that, considering all the pain I went through to figure out what ButtonState() and KeyState() do.

[OrbWeaver]

Not really a DarkRadiant issue...

[Nyarlathotep]

No. Darkmod issue.

[Ishtvan]

Ah. Could you point out (approximately) where it is in the code? I can probably fix it myself, although there may be some problems getting the lean-code to handle non-ASCII inputs.

I don't know much about it myself, but it looks like a ButtonStateTracker class was added, /src/Darkmod/ButtonStateTracker. It seems to call PerformKeyRelease(impulse, holdTime), when a key is released.

 

It looks like we just have to add handling of the lean impulses to idPlayer::PerformKeyRelease. (This is in /src/game/player.cpp). So look for the lean impulses in the ::PerformImpulse part of idPlayer, note the impulse number and which direction they lean in (the argument of ToggleLean). Then go into ::PerformKeyRelease, add cases fro the same impulses and call ToggleLean again with the same argument, to lean back when the key is released.

 

Seems pretty straightforward, and hopefully the lean physics code should handle it because it used to do this when we had the old keyhandler. Btw, if an admin can move this to bug reports or programming or something, that would be appreciated.

[greebo]

Yes, I wrote the ButtonStateTracker to call the PerformKeyRelease() method on idPlayer. Just add your IMPULSE_YY to the switch and update the leaning.

[Nyarlathotep]

I've uploaded a new pk4 to svn. Lean is now a hold, rather than a toggle. Still a bit buggy, though, if you quickly press and release the button.

[SneaksieDave]

Are we able to leave support for both as a player option? IIRC, after the first-generation button support was in place, toggle lean was sufficiently non-objectionable (to some) to actually warrant leaving it up to player preference.

[Nyarlathotep]

Done. Sneaksie, meet pm_lean_toggle; pm_lean_toggle, meet SneaksieDave. It defaults to hold for lean, btw.

[Ishtvan]

I've uploaded a new pk4 to svn. Lean is now a hold, rather than a toggle. Still a bit buggy, though, if you quickly press and release the button.

Cool!

 

Some of the bugginess might be due to the lean physics itself, it doesn't like it when you try to toggle and then toggle back or toggle another way too soon. It probably needs an overhaul with better support of interruptions, and also making you wait until you've leaned all the way back when switching from side/side lean to forward/back lean and vice versa (that causes a different bug).

[Nyarlathotep]

I hacked in a simple fix to keep players from being able to toggle lean on (with pm_lean_toggle set to 0) by leaning then double-tapping the same lean key, but I haven't committed it yet. It forces the player to wait a lot longer than I'm comfortable with. I would say that the overhaul needs to support going back into a lean before finishing the return to vertical. That is, do like in Thief, where you release the button, and then press it again before you finish returning to vertical, you immediately start moving to the (potentially new) lean direction.

 

Wow, I really wish I could explain that better. Perhaps I should add it to my to-do (eventually) list?

 

Edit: Oh, my current version also fixes the typo I made with pm_lean_toggle. (pm_lean_togggle? Oh no!) I should probably upload it already.

[Komag]

Great news, thanks for the quick fix

[SneaksieDave]

Cool checking it out now... works gggreat!

 

And yeah there is definitely something funky about leaning too soon after leaning a different way. Try leaning all the way right, and then before you've re-centered, lean forward.

[Nyarlathotep]

That was already an issue, before I made the changes.

[Ishtvan]

That's actually two separate issues. Leaning left, then letting go too soon or leaning right again too soon cause some unresponsiveness problems. Leaning left, then leaning forward is a separate problem stemming from starting a forward lean while you are in the left lean state, it doesn't matter how long you wait between doing those two things.