Jump to content
The Dark Mod Forums
Sign in to follow this  
grayman

Weird compass in SVN

Recommended Posts

I haven't updated from SVN (assets/source) in a while, and I recall some mention of this problem in some thread, but I can't find the thread, and I can't find a bug report for the problem.

 

Just noticed this in my WIP.

 

post-3633-0-65752100-1538447784_thumb.jpg

 

'nuff said.

Share this post


Link to post
Share on other sites

I haven't updated from SVN (assets/source) in a while, and I recall some mention of this problem in some thread, but I can't find the thread, and I can't find a bug report for the problem.

 

Just noticed this in my WIP.

 

attachicon.gifcompass.jpg

 

'nuff said.

I can't repeat that compass background bug. Please attach your .cfg and if easy a test map or a map name where this plays up.

I can see however a compass offset on the screen with r_fboResolution < 0.

Share this post


Link to post
Share on other sites

I started "A New Job" and the problem was there.

 

Since I'm working on the keyhole addition, I'm building my own binaries, so ...

 

I deleted my binaries.

 

I updated to the current SVN binaries and assets.

 

I started "A New Job" again and the problem was gone.

 

I then updated to the latest source and rebuilt the binaries w/ my keyhole changes.

 

The problem returned.

 

So now I suspect something I'm doing is causing the problem, though I'm not working anywhere in the area of icon presentation or the painting of the compass.

 

I'll post a bugtracker for myself and get back to it when I can.

 

Btw, my r_fboResolution is "1" throughout all this.

 

Thanks.

Share this post


Link to post
Share on other sites

I started "A New Job" and the problem was there.

 

Since I'm working on the keyhole addition, I'm building my own binaries, so ...

 

I deleted my binaries.

 

I updated to the current SVN binaries and assets.

 

I started "A New Job" again and the problem was gone.

 

I then updated to the latest source and rebuilt the binaries w/ my keyhole changes.

 

The problem returned.

 

So now I suspect something I'm doing is causing the problem, though I'm not working anywhere in the area of icon presentation or the painting of the compass.

 

 

I'll post a bugtracker for myself and get back to it when I can.

 

Btw, my r_fboResolution is "1" throughout all this.

 

Thanks.

I can't see the weird background there but the compass draws half-shadowed. I suppose that's not good?

Never mind, it's my local changes.

post-3508-0-44392100-1538481694_thumb.jpg

Share this post


Link to post
Share on other sites

Copied from the tracker:

 

I have seen this too.

 

I believe the problem lies in the fact that the compass is rendered in a

GUI where there is broken stub code for the lighting since the

changes described in 0004569.

 

In older engine builds, this simply broke the lighting but now all rendering is

predicated on having the correct FBO attributes and the broken stub code is not

generating the source data for the FBO's.

Share this post


Link to post
Share on other sites

Tested. Got the same result in 32- and 64-bit. The initial problem is fixed, but when looking straight down, there's a circular shadow on the compass.

 

post-3633-0-14224300-1543538078_thumb.jpg

 

This is with Soft Shadows on and set to Low.

 

If I turn Soft Shadows off, the circle goes away.

 

 

Share this post


Link to post
Share on other sites

Another issue:

 

Single pass shadow maps sometimes make the compass render black.

 

r_shadows 2

r_shadowMapSinglepass 1

 

Quickest replication:

 

1) Install mission Closemouthed Shadows

2) After the mission starts open the console and type:

 

spawn atdm:playertools_compass

 

3) Cycle Inventory until the Compass appears

 

With the default r_shadowMapSinglepass enabled, the compass will be black

but moving around will sometimes illuminate it.

 

Disabling r_shadowMapSinglepass causes it to remain visible with no artifacts

including the issue reported above.

Share this post


Link to post
Share on other sites

Tested. Got the same result in 32- and 64-bit. The initial problem is fixed, but when looking straight down, there's a circular shadow on the compass.

 

attachicon.gifcompass.jpg

 

This is with Soft Shadows on and set to Low.

 

If I turn Soft Shadows off, the circle goes away.

 

 

Umm...

The trivial fix is to add a noshadows flag to the compass light (which is also healthy in the performance aspect).

Committed to svn. Please advise if I went in the wrong direction.

Share this post


Link to post
Share on other sites

Another issue:

 

Single pass shadow maps sometimes make the compass render black.

 

r_shadows 2

r_shadowMapSinglepass 1

 

Quickest replication:

 

1) Install mission Closemouthed Shadows

2) After the mission starts open the console and type:

 

spawn atdm:playertools_compass

 

3) Cycle Inventory until the Compass appears

 

With the default r_shadowMapSinglepass enabled, the compass will be black

but moving around will sometimes illuminate it.

 

Disabling r_shadowMapSinglepass causes it to remain visible with no artifacts

including the issue reported above.

Sorry, can't repeat

 

post-3508-0-51729300-1543595146_thumb.jpg

Share this post


Link to post
Share on other sites

Still happening for me.

Also it seems that screenshot caused the shadow to toggle off :(

 

post-3763-0-95016900-1543599600_thumb.jpg

 

On the bright side, Stencil Shadow mode is fixed. :)

Share this post


Link to post
Share on other sites

For me, the original problem is fixed, and the secondary problem of seeing the circle on the compass with soft shadows on has also been fixed.

 

Good work, thx!

Share this post


Link to post
Share on other sites

r_softShadowsRadius -0.65

 

r_softShadowsQuality 24

I'm afraid we should pause on the single pass shadow maps for now

The GS appears to be too slow for the task.

Our current code does it on the CPU only when interaction is created/changes. It's slow with dynamic interactions, but there are not too many of them.

I hoped the GS could do it in real time but alas it's about 40% slower than using the pre-computed index subsets

Share this post


Link to post
Share on other sites

Still happening for me.

 

Also it seems that screenshot caused the shadow to toggle off :(

 

attachicon.gifclosemouthed_shadows_2018-11-30_12.37.58.jpg

 

On the bright side, Stencil Shadow mode is fixed. :)

Try now

 

I don't know why it was only the single pass broken but there was a bigger problem of duplicate/unnecessary views generated by the frontend

  • Like 1

Share this post


Link to post
Share on other sites

Still not quite cured...

 

Same Closemouthed Shadows replication except the compass renders correctly until

you enter the room with the fireplace where the compass turns black.

  • Like 1

Share this post


Link to post
Share on other sites

Still not quite cured...

 

Same Closemouthed Shadows replication except the compass renders correctly until

you enter the room with the fireplace where the compass turns black.

Please test

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Sign in to follow this  

×
×
  • Create New...