name_attach not present in def file(s)

[datiswous]

As mentioned in this post:

https://wiki.thedarkmod.com/index.php?title=Combined_light_entities#Example_entities

Quote

Setting a spawnarg on the attached entity is simply done by setting the spawnarg set SPAWNARGNAME on ATTACHMENTNAME on the base entity. SPAWNARGNAME is the name of the spawnarg, while the attachment name can be looked up in the entityDef for the base entity, e.g. in DR by checking the "Show inherited" in the entity inspector.

The ATTACHMENTNAME is defined as name_attach spawnarg on either the base entity or one of its attached entities.

In the entity atdm:sconce_2candles_rigid there's no name_attach . I think the name_attach should be present inside the def file?

Maybe there are more def files where no name_attach is present. For example:

atdm_ship_lamp_lit
atdm_standing_chandelier_3_candles
atdm_lamp_hanging02

[Frost_Salamander]

The entities you mention don't have a def_attach for the light so they don't need a name_attach.  If you want to change the light properties you can do it directly on the entity instead of using 'set key on name_attach' like you would on other 'combined' light entities.

I don't know what these types of entities are called or how they are put together (I haven't looked into it), but that's the difference in how you customise them.  Maybe they inherit from some parent that combines lights and models instead of using attachments.

I think in that newbie question thread the sconce object was just an entity that someone forgot to add the name_attach spawnargs on.

Edited December 4, 2023 by Frost_Salamander

[datiswous]

2 hours ago, Frost_Salamander said:

The entities you mention don't have a def_attach for the light so they don't need a name_attach.

atdm:sconce_2candles_rigid  and  atdm_standing_chandelier_3_candles  do have a def_attach.

Yeah ok the other two work differently.

2 hours ago, Frost_Salamander said:

I think in that newbie question thread the sconce object was just an entity that someone forgot to add the name_attach spawnargs on.

I think it would be more useful if the name_attach is already in the def file.

Edited December 4, 2023 by datiswous

[Frost_Salamander]

22 minutes ago, datiswous said:

I think it would be more useful if the name_attach is already in the def file.

Agreed! Why not file a bug report?