Segfault In Latest Build

[OrbWeaver]

I get a segfault with the latest build (checked in today). Here is the stacktrace:

 

Thread [1] (Suspended: Signal 'SIGSEGV' received. Description: Segmentation fault.)	
31 std::string::compare()  0xb76059dc	
30 std::operator< <char, std::char_traits<char>, std::allocator<char> >() at /usr/include/c++/4.0.3/bits/basic_string.h:2208 0xb710f0ac	
29 std::less<std::string const>::operator() at /usr/include/c++/4.0.3/bits/stl_function.h:227 0xb710f0da	
28 std::_Rb_tree<std::string const, std::pair<std::string const, unsigned int>, std::_Select1st<std::pair<std::string const, unsigned int> >, std::less<std::string const>, std::allocator<std::pair<std::string const, unsigned int> > >::find() at /usr/include/c++/4.0.3/bits/stl_tree.h:1135 0xb711a65b	
27 std::map<std::string const, unsigned int, std::less<std::string const>, std::allocator<std::pair<std::string const, unsigned int> > >::find() at /usr/include/c++/4.0.3/bits/stl_map.h:498 0xb711a753	
26 Modifiers::getModifierBitIndex() at DarkRadiant/plugins/eventmanager/Modifiers.cpp:104 0xb7117da7	
25 Modifiers::getModifierFlags() at DarkRadiant/plugins/eventmanager/Modifiers.cpp:69 0xb7119159	
24 EventManager::addAccelerator() at DarkRadiant/plugins/eventmanager/EventManager.cpp:111 0xb7111c41	
23 Brush_registerCommands() at DarkRadiant/radiant/brushmanip.cpp:1166 0x080613a2	
22 BrushModuleClass::construct() at DarkRadiant/radiant/brush/BrushModule.cpp:67 0x08210f00	
21 BrushDoom3API() at DarkRadiant/radiant/brush/BrushModule.cpp:173 0x082126ed	
20 DefaultAPIConstructor<BrushDoom3API, BrushDependencies>::constructAPI() at DarkRadiant/libs/modulesystem/singletonmodule.h:42 0x08212771	
19 SingletonModule<BrushDoom3API, BrushDependencies, DefaultAPIConstructor<BrushDoom3API, BrushDependencies> >::capture() at DarkRadiant/libs/modulesystem/singletonmodule.h:124 0x08212d56	
18 SingletonModuleRef<BrushCreator>::capture() at DarkRadiant/include/modulesystem.h:204 0xb6fd92a6	
17 GlobalModuleRef() at DarkRadiant/include/modulesystem.h:246 0xb6fdb116	
16 MapDoom3Dependencies() at DarkRadiant/plugins/mapdoom3/mapdoom3.cpp:58 0xb6fdc6dd	
15 SingletonModule<MapDoom3API, MapDoom3Dependencies, DependenciesAPIConstructor<MapDoom3API, MapDoom3Dependencies> >::capture() at DarkRadiant/libs/modulesystem/singletonmodule.h:120 0xb6fdeb23	
14 ModulesMap<MapFormat>::insert() at DarkRadiant/libs/modulesystem/modulesmap.h:58 0x080f45d2	
13 ModulesRef() at DarkRadiant/libs/modulesystem/modulesmap.h:145 0x080f4804	
12 ReferenceDependencies() at DarkRadiant/radiant/referencecache.cpp:818 0x08112539	
11 SingletonModule<ReferenceAPI, ReferenceDependencies, DefaultAPIConstructor<ReferenceAPI, ReferenceDependencies> >::capture() at DarkRadiant/libs/modulesystem/singletonmodule.h:120 0x08112a87	
10 SingletonModuleRef<ReferenceCache>::capture() at DarkRadiant/include/modulesystem.h:204 0xb628534e	
9 GlobalModuleRef() at DarkRadiant/include/modulesystem.h:246 0xb62867f2	
8 EntityDependencies() at DarkRadiant/plugins/entity/plugin.cpp:62 0xb62872fa	
7 SingletonModule<EntityDoom3API, EntityDependencies, DefaultAPIConstructor<EntityDoom3API, EntityDependencies> >::capture() at DarkRadiant/libs/modulesystem/singletonmodule.h:120 0xb6287557	
6 SingletonModuleRef<EntityCreator>::capture() at DarkRadiant/include/modulesystem.h:204 0x080efc00	
5 GlobalModuleRef() at DarkRadiant/include/modulesystem.h:246 0x080f26b4	
4 RadiantDependencies() at DarkRadiant/radiant/plugin.cpp:227 0x080f4de4	
3 Radiant_Construct() at DarkRadiant/radiant/plugin.cpp:326 0x080ed8dc	
2 Radiant_Initialise() at DarkRadiant/radiant/mainframe.cpp:669 0x080a4b37	
1 main() at DarkRadiant/radiant/main.cpp:529 0x08099294

 

For some reason there seems to be a gap in the callstack between this in Brush_registerCommands():

 

	GlobalEventManager().addCommand("BrushPrism", BrushPrefab::SetCaller(g_brushprism));

 

and EventManager::addAccelerator(), which seems to be called with two unitialised strings. I am not sure why this is, as I would expect there to be a stack entry for EventManager::addCommand() which is what is actually being called, but GDB's usefulness does seem to degrade over time so maybe it is just missing stuff out.

[greebo]

I will look into it right now!

[greebo]

Could you send me your user.xml and your input.xml to greebo@angua.at? I think this is related to loading the accelerators, as this is the only way the addAccelerator() method gets called.

[OrbWeaver]

Sent.

[greebo]

Hm, so far no crash. I will try to dump the output during the accelerator load process and see if there is something weird in it.

[OrbWeaver]

I did a full sweep-and-clear and removed my local XML files, and the problem has now gone away (should have remembered to try this before reporting the problem).

[greebo]

Still, leaving a user.xml in the local folders should not lead into a segfault. It's not really obvious too, as I check for empty strings before passing them to addAccelerator(). So I'm a bit lost why this could happen.

 

However, I already added some debug possibilites into the EventManager class and I will commit them, they might come handy.