How do I exit while loop script timer?

[Fidcal]

My script has:

 

while(global >=0 && global < Time)
{
sys.wait(1);
global ++;
}

 

A separate function correctly triggers and sets global to -1 but the above timer continues to count up to Time. Why?

[Obsttorte]

can you please post the full script file here, so it's easier to find your mistake?

[grayman]

Because when your sys.wait(1) expires, the first thing the script does is change global from -1 to 0. The "while" statement sees that global equals 0, and it continues operating.

 

To get the loop to exit, either have your separate function set global to -2 or Time.

[Fidcal]

Ah - so the 'while loop doesn't immediately exit when untrue but only at the end? Yes, of course, it tests at the end. I did originally set global to -99 to avoid that sort of thing when I was doing a different sort of loop then I somehow changed it to -1. Thanks grayman.

[grayman]

It actually tests at the beginning of the loop. This allows the loop to detect the very first time through whether it should run at all.

 

To test at the end of the loop, you do this:

 

do
{
 sys.wait(1);
 global++;
} while ( ( global >= 0 ) && ( global < Time ) );

 

This form of the loop allows one instance to run before checking whether to continue;

[Tels]

What grayman said. The reason why it did not exit for you was due to syncronising issue - the "set to -1" happened randomly at any time during the loop, so it was likely it happens during the 1s wait time.

 

Also, is "Time" a variable in your loop, e.g. it should run until X seconds are over or it is interrupted?

[Fidcal]

Strictly speaking, Time should be a constant. I set it to a variable while developing to see what works best. 8 secs seems OK and I'm too lazy to keep checking how to set a constant in doom script which I keep forgetting. Makes little difference to the working but is really for code clarity.

[Tels]

You can either set a variable:

 

float time; time = 8;

 

(I forgot if "float time = 8; works, sometimes D3 doesn't like that style...)

 

or simple use "8" in the code:

 

while (duration++ < 8)
 {
 sys.wait(1);
 }

 

I usually define a function for such a task and make the time etc. a parameter, so you can call it with different times w/o having to change the code that does the actual work.

[Fidcal]

I used the former - declared it as a variable - because it is needed again further on in the code.