Bugs I'm encountering in latest Git master

[greebo 62]

On 1/17/2021 at 11:44 PM, MirceaKitsune said:

Latest Git master has a few new issues. First some maps will instantly crash DR when opened: This happens because of that map's map.darkradiant file, it goes away when the following line is manually deleted from it (the MapProperties section):

KeyValue { "LastShaderClipboardMaterial" "textures/common/caulk" }

 

I don't have time the next few days, can you please push this to the bugtracker?

[MirceaKitsune 258]

19 hours ago, greebo said:

I don't have time the next few days, can you please push this to the bugtracker?

Done.

[MirceaKitsune 258]

Latest Git master fails to compile with a build error. Noticed while trying to test an issue I have a feedback on.

[ 49%] Building CXX object radiantcore/CMakeFiles/radiantcore.dir/map/Map.cpp.o
/home/mircea/Games/Quake/TheDarkMod/DarkRadiant_GIT/radiantcore/map/Map.cpp: In member function ‘void map::Map::loadPrefabAt(const ArgumentList&)’:
/home/mircea/Games/Quake/TheDarkMod/DarkRadiant_GIT/radiantcore/map/Map.cpp:661:76: error: ‘GlobalGrid’ was not declared in this scope
  661 |         auto prefabCenter = accumulator.getBounds().getOrigin().getSnapped(GlobalGrid().getGridSize());
      |                                                                            ^~~~~~~~~~
make[2]: *** [radiantcore/CMakeFiles/radiantcore.dir/build.make:1577: radiantcore/CMakeFiles/radiantcore.dir/map/Map.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:785: radiantcore/CMakeFiles/radiantcore.dir/all] Error 2
make: *** [Makefile:149: all] Error 2

 

[greebo 62]

Thanks, should be fixed

[MirceaKitsune 258]

Thanks. I'm still not seeing the conversation editor in latest Git master from today though, looked closely in all of the menus to be sure: Could I be missing something, or perhaps there's still a problem that keeps the plugin from being detected and appearing?

[greebo 62]

I haven't merged orbweaver's branch yet.