Feature request: emissive materials/volumetric lights

[duzenko 659]

 

Ok, I made the change, only the spot light uses the light_shaft material now, other lights use stock falloff_exp2. https://we.tl/t-lGvhXwFaYI

 

As for the performance, the window is 338 tris, shadow tris in that scene take up around 500. It's easier to use a physical model right now, as you don't have to line up things. Fake projection it will be a PITA anyway, since you'll have to make a window noshadows, carve some space behind to line up the light with projection etc. IMO the order of testing should be: 1) a physical model, 2) a plane with alphatest transparency, 3) a light with projection texture.

Makes sense. Not an issue for small rooms.

[duzenko 659]

Without the custom projection it's just a re-implementation of the fog light

 

https://drive.google.com/file/d/1dqR1zaOADwkWO9bRN0JlHZatL63mzbJK/view?usp=sharing

[peter_spy 1603]

That's weird, geometry should occlude such lights as well.

[nbohr1more 2162]

Any way to make this new features automatically match the light color?

[peter_spy 1603]

In this version you have 2 windows:

1) the one from previous version, it cast shadows

2) a clone that has noshadows 1 spawnarg and a spotlight with projection texture behind it

 

https://we.tl/t-2UfOjvvuO2

 

Btw. what does the exe file in that link do?

Edited September 27, 2018 by Judith

[duzenko 659]

Any way to make this new features automatically match the light color?

So simple I left it for the end.

 

In this version you have 2 windows:

1) the one from previous version, it cast shadows

2) a clone that has noshadows 1 spawnarg and a spotlight with projection texture behind it

 

https://we.tl/t-2UfOjvvuO2

 

Btw. what does the exe file in that link do?

That's the test volumetric build

[duzenko 659]

In this version you have 2 windows:

1) the one from previous version, it cast shadows

2) a clone that has noshadows 1 spawnarg and a spotlight with projection texture behind it

 

https://we.tl/t-2UfOjvvuO2

 

Btw. what does the exe file in that link do?

You have four lights in that room.

I think you should only set the volumetric flag for the floor lights. The window lights are better off without it.

Here's the test build

https://drive.google.com/file/d/1dqR1zaOADwkWO9bRN0JlHZatL63mzbJK/view?usp=sharing

[HMart 334]

Without the custom projection it's just a re-implementation of the fog light

 

https://drive.google.com/file/d/1dqR1zaOADwkWO9bRN0JlHZatL63mzbJK/view?usp=sharing

 

Hum that just means the current implementation does not support occlusion, what would happen if you put a object in front of the beam?

 

something like this

 

Edited September 27, 2018 by HMart

[duzenko 659]

 

Hum that just means the current implementation does not support occlusion, what would happen if you put a object in front of the beam?

 

something like this

 

 

I'm going to add a shadow test to the shader at some point, but it can only work with shadow maps.

[peter_spy 1603]

You have four lights in that room.

I think you should only set the volumetric flag for the floor lights. The window lights are better off without it.

Here's the test build

https://drive.google.com/file/d/1dqR1zaOADwkWO9bRN0JlHZatL63mzbJK/view?usp=sharing

 

Yup, the two lights nearby the windows are there just to illuminate the frame. They use stock falloff_exp2 texture and they're no shadows, so they're not messing with anything. Only the spotlights have custom light materials with volumetric keyword. Downloading the test build.

[Bikerdude 3741]

https://drive.google.com/file/d/1dqR1zaOADwkWO9bRN0JlHZatL63mzbJK/view?usp=sharing

This looks fantastic!

[duzenko 659]

 

Yup, the two lights nearby the windows are there just to illuminate the frame. They use stock falloff_exp2 texture and they're no shadows, so they're not messing with anything. Only the spotlights have custom light materials with volumetric keyword. Downloading the test build.

Then it's a problem on my side. I will double check that.

[peter_spy 1603]

 

Alright, we're going somewhere, but right now the faces of the volume are kind of flipped, and there's no "inside".

[peter_spy 1603]

Ok, when I get inside the light cone and look at the window, the effect looks kinda correct:

 

But when I turn around:

[duzenko 659]

 

 

Alright, we're going somewhere, but right now the faces of the volume are kind of flipped, and there's no "inside".

I'm pretty sure you have the wrong shaders. You need to put the fs/vs files in \glprogs.

 

I double checked the lights and now only the floor lights are affected - so that's sorted.

It's back again.

[duzenko 659]

The volumetric keyword bug fixed. Now only the floor lights should be affected.

https://drive.google.com/file/d/1dqR1zaOADwkWO9bRN0JlHZatL63mzbJK/view?usp=sharing

Oh, BTW, there's another bug with the depth texture that you need to have r_fbo 1, otherwise the depth test will fail.

[Bikerdude 3741]

Question -

 

Whats the relative hits of perf. for the different version's of this new feature..? and will they be mapper selectable..?

Edited September 27, 2018 by Bikerdude

[peter_spy 1603]

Now were talking

 

One small thing to fix would be these black lines at the light cone boundaries:

[Bikerdude 3741]

Is that the same room as above? if so when inside the volume the reast of the room should appear dark should it not..?

Edited September 27, 2018 by Bikerdude

[duzenko 659]

Question -

 

Whats the relative hits of perf. for the different version's of this new feature..?

I expect it to be costly enough, depending on the desired quality. The current version does 120 texture samples per pixel which is a lot. We have to do that many samples because we're taking integral of a function in a range, and few sample mean visible banding.

 

and will they be mapper selectable..?

As selectable as the test map in this thread.

[duzenko 659]

Now were talking

 

One small thing to fix would be these black lines at the light cone boundaries:

 

http://bugs.thedarkmod.com/view.php?id=4888

[duzenko 659]

Is that the same room as above? if so when inside the volume the reast of the room should appear dark should it not..?

Not really. The dust in the light cone is still visible when you're inside the cone too.

[peter_spy 1603]

Btw. I'd refrain from all the distracting questions and what-ifs until we have a basic functionality ready. Next thing will be the proper use of light color and intensity.

[peter_spy 1603]

Another weird thing, look at the lightgem:

 

I'm standing in the same spot, I just moved my head up.

[Bikerdude 3741]

The dust in the light cone is still visible when you're inside the cone too.

Your gonna get some light bounce for sure, but in RL the dust wouldnt allow you to see the rest of the room as if you had raised the gamma.

 

While trying a photgraphic example (still looking) I found this -

 

Edited September 27, 2018 by Bikerdude