Jump to content
The Dark Mod Forums

[Resolved] Allow mantling while carrying a body


Daft Mugi

Recommended Posts

On 5/2/2023 at 1:44 PM, snatcher said:

Allow mantling while carrying my lucky dice? No?

Carrying an object is treated differently than shouldering a body in the code. I suppose the original thinking was that the player can't mantle while using both "hands" to carry something.

I've put it on my list of things to investigate. Stay tuned.

Link to comment
Share on other sites

15 hours ago, Daft Mugi said:

I suppose the original thinking was that the player can't mantle while using both "hands" to carry something.

I suppose. I also suppose players would naturally try to mantle while carrying a candle only to find out this is unnaturally restricted, regardless of the justifications.

15 hours ago, Daft Mugi said:

I've put it on my list of things to investigate. Stay tuned.

Many thanks in advance, Daft Mugi.

The show stopper happens in lines 5055 and 5056 of file game\physics\Physics_Player.cpp:

    // Ishtvan: Do not attempt to mantle if holding an object
    if( gameLocal.m_Grabber->GetSelected() )
        return;

I wonder what would happen if these lines are commented out, if only for testing purposes... I am specially interested in seeing what happens with jumps.

TDM_Modpack_Thumb.png

Link to comment
Share on other sites

  • 3 months later...

This is most excellent news, @Daft Mugi! Thanks for your commitment and for your work.

Now, I haven't tested anything nor checked the code but I guess you applied similar limitations than when shouldering bodies. Apologies in advance if this is not the case. At the risk of sounding ungrateful I will say something the same: I already suggested somewhere else that it would be ideal if you include in your workflow going forward a step to see if parts of the code you work on can be made script-friendly. I have seen scripts making use of functionality - previously made available by others - in the most peculiar ways. I would say, from the little experience I have, that even the most irrelevant variable or function can make a difference when realizing that mad idea in a map or as a mod.

Having said that and once again: thank you very much for the efforts and for sharing the results with us.

TDM_Modpack_Thumb.png

Link to comment
Share on other sites

7 hours ago, snatcher said:

Now, I haven't tested anything nor checked the code

The latest dev build includes it.

7 hours ago, snatcher said:

I guess you applied similar limitations than when shouldering bodies. Apologies in advance if this is not the case.

Yes, very similar limitations. There's a new cvar to adjust allowed mantle height while carrying an object.

The default is set to closely match the limitations of mantle while shouldering. Here's a video showing the limitations.

 

7 hours ago, snatcher said:

At the risk of sounding ungrateful I will say something the same: I already suggested somewhere else that it would be ideal if you include in your workflow going forward a step to see if parts of the code you work on can be made script-friendly.

I'm not sure what scripting would like for this.

7 hours ago, snatcher said:

Having said that and once again: thank you very much for the efforts and for sharing the results with us.

You're welcome!

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Recent Status Updates

    • taaaki

      Apologies for the unplanned downtime. A routine upgrade did not go to plan, and the rollback had its own issues
      · 2 replies
    • freyk

      Got tdm 2.12 running on my android phone. For more info, read the latest post in the topic on subforum techsupport.
      · 2 replies
    • snatcher

      TDM Modpack v4.5 released!
      Introducing... The Loop
      · 1 reply
    • Ansome

      Taking a break to alleviate burnout. In retrospect, I probably shouldn't have jumped into a map-making contest so quickly after just finishing another project and especially with my busy schedule, but I do believe I have something that the community will enjoy. No clue if I'll be able to finish it on time for the competition if I factor in a break, but I'd rather take my time and deliver something of quality rather than engage in development crunch or lose part of the map's soul to burnout.
      · 1 reply
    • Skaruts

      Working on an update for my mission By The Cookbook. If anyone that played it has any further bugs to report, please let me know.
      I posted more details about the update in the mission thread.
      · 1 reply
×
×
  • Create New...