[Feature Proposal] Frob to Use World Item

[snatcher]

One of the first things I did when 2.12 was out was to code shouldering on hold-frob here, locally. I have been using my ad-hoc executable ever since with zero issues.

What troubles me to this day is that you people never got to test other shouldering alternatives. Sure, @stgatilov provided the double click but it was quickly discarded because this approach is rarely found in games. In the end, we were forced to choose between Thief-like or nothing: no wonder this topic quickly turned into such a heated discussion.

The second thing that troubles me is how easily body manipulation was discarded. Sure, not many games have such fine control over bodies but, doesn't that alone make body manipulation unique and special in our game? Body manipulation is unusable in its current version, in my humble opinion. Such a loss.

We were told further changes might make it into 2.13 and I have been patiently waiting but months went by and I haven't heard anything therefore please find attached to this post my game/Player.cpp. It was made for 2.12 but can be easily ported to newer versions of TDM. I have just added some comments to the file. Look for my name for the changes.

Please note I will not be providing an executable. This isn't the purpose of my post and you need to build the solution yourself if you want to try it. The purpose of my post is to say that nothing is impossible and we can have everything, and I remain available to assist if there ever is the will to complete this, half-baked initiative.

Player.cpp

[nbohr1more]

I'll take a look. I don't have much skin in the game regarding this topic but I am a little frustrated about how awkward ragdoll manipulation now works.

@Daft Mugi is probably the one who has the most investment in this topic.

[snatcher]

Ok, let's make this clear:

1. My proposal is to keep things the way they are but to have shouldering on quick-frob (default) or hold-frob as an option.
2. My game/Player.cpp does not include a full solution, only shouldering on hold-frob for testing purposes.

[nbohr1more]

After fiddling with this patch, I do like it but I am also now proficient in the "new 2.12 way" so I don't really have a preference I guess?

I suppose we should offer this as an option?

Here is the latest 2.13 SVN file patched with snatcher changes:

Player.cpp

[wesp5]

I got used to the current version very fast, but for consistency I suggest to add the option to the base game!

[snatcher]

Keep it simple, yet descriptive:

Stick to a hidden "Normal" Hold-Frob duration, at least for the first release. Collect feedback. Adjust or add options when required, not before.

[snatcher]

Find attached to this post the (almost) full solution.

Files edited:

• game\Player.cpp
• game\gamesys\SysCvar.h
• game\gamesys\SysCvar.cpp

I took fresh sources this morning from: https://svn.thedarkmod.com/publicsvn/darkmod_src/trunk/

I added a master cvar tdm_holdfrob_shouldering to control A or B:

• 0 = Shoulder/unshoulder on frob [default]
• 1 = Shoulder/unshoulder on hold-frob

@Daft Mugi's implementation remains 100% genuine as long as tdm_holdfrob_shouldering remains 0.

I say "almost" full solution because I added menu strings directly in mainmenu_settings_gameplay.gui instead of using lang files. Should the solution get approved this will, of course, change.

--------------------------------------------------

There's the possibility that cvar tdm_holdfrob_delay is currently set to 0 in your install. Manually set it to 300 [default] using the console if this is the case.

HoldFrobBodies_v0.1.zip mainmenu_settings_gameplay.gui

[nbohr1more]

I love it! @stgatilov ?

[snatcher]

If this solution (or similar) makes it into the game we will have to review at some point:

• tdm_holdfrob_delay / cv_holdfrob_delay
• CanHoldFrobAction()

There is an excess of code / code-checks now.

It would be worth reviewing as well:

• tdm_holdfrob_drag_body_behavior / cv_holdfrob_drag_body_behavior
• tdm_holdfrob_drag_all_entities / cv_holdfrob_drag_all_entities

[stgatilov]

As far as I see, currently there is "2.11 mode" in the code, and this new patch removes it.
No idea how many people still use that old mode, and how many people will like this new mode.
So obviously we can't make a decision.

I think it is rather obvious why nobody worked on it: everyone remembers how painful it was.
And @Daft Mugi is perfectly OK with his Thief-like mode, I suppose.

[snatcher]

1 hour ago, stgatilov said:

As far as I see, currently there is "2.11 mode" in the code, and this new patch removes it.

No, "2.11 mode" has been upgraded to "2.11 + hold-frob". Nothing is lost, more is added.

This patch meets the requirements of all voices heard in this topic. A happy ending.

[snatcher]

@stgatilov, have you tried my patch (including the gui) and is it 100% clear what it does? Do not hesitate to ask otherwise. I won't be bringing this topic again after 2.13.