X-Ray Glasses Script Update

[snatcher]

Iris: X-Ray Glasses Script Update

Hey,

I have fixed & simplified the "Peculiar Lenses" (or X-Ray Glasses) script for "Iris" (current official version) by @Wellingtoncrab

1) With the glasses on, if we use the inventory grid we currently get:

I have exchanged:

overlayHandle = $player1.createOverlay(getKey("gui"), ZOOM_GUI_LAYER);

with:

overlayHandle = $player1.createOverlay(getKey("gui"), -1);

And now the inventory grid shows up in the proper layer:

2) There's a "Cooldown period" going on when you use the glasses that prevents players from getting the glasses on and off instantly. I personally find it a little unnerving that I am forced to wait when, in example, I put on or remove the glasses by mistake. I understand the reasons why this was done but it isn't well executed (lack of graphical context) and I find it at times a little frustrating and I have removed all references to "xrayGlassesCooldown".

3) There's a "loot_loop()" method that prevents the glasses from moving away from the inventory when picking up loot. Once again, I kind of understand the reasons why this was done but I don't understand why it is limited to a single item and it breaks consistency in example, when players pick up or select a different item. When I first played Iris I was at times puzzled because I didn't understand why glasses sometimes stay and other times vanish and I have removed it.

Find attached to this post the *.pk4 which includes the old and new versions of the xray_glasses script. Download it and place it in "/fms/iris/".

Please note this script will not work in any mission other than "Iris".

zzz_iris_xray_glasses_script.pk4

[snatcher]

Written In Stone: X-Ray Glasses Script Update

I have fixed & simplified the "Magic Glasses" (or X-Ray Glasses) script for "Written in Stone" (current official version) by @Dragofer, @Amadeus, @B1k3rdude.

1) With the glasses on, if we use the inventory grid we currently get:

I have changed:

overlayHandle = $player1.createOverlay(getKey("gui"), ZOOM_GUI_LAYER);

with:

overlayHandle = $player1.createOverlay(getKey("gui"), -1);

And now the inventory grid shows up in the proper layer:

2) There's a "Cooldown period" going on when you use the glasses that prevents players from getting the glasses on and off instantly. I personally find it a little unnerving that I am forced to wait when, in example, I put on or remove the glasses by mistake. I understand the reasons why this was done but it isn't well executed (lack of graphical context) and I find it at times a little frustrating and I have removed all references to "xrayGlassesCooldown". For this to work I also had to edit written_misc.script.

3) There's a "loot_loop()" method that prevents the glasses from moving away from the inventory while (wearing the glasses and) picking up items. Once again, I understand the reasons why this was done and while this script is better than the one found in "Iris" it has its problems: if you pick up an item (other than loot) while wearing the glasses you cannot tell which item you just picked because the inventory quickly switches back to the glasses.

Find attached to this post the *.pk4 which includes old and new versions of the xray_glasses script and written_misc.script. Download it and place it in "/fms/written/".

Please note this script will not work in any mission other than "Written in Stone".

zzz_written_xray_glasses_script.pk4

Edited July 29, 2023 by snatcher

[snatcher]

Allow me to complete this exercise by saying there still are issues with the X-Ray glasses in "Written in Stone" when trying to use them along with the Spyglass. Right now the Spyglass is kind of restricted but not too much, and the code to limit usage of the Spyglass is all over the place. This can change, but not today.

[wesp5]

With your permission I will include the inventory fix into the Unofficial Patch, but I won't touch the other issues as these seem to be intended according to Wellingtoncrab.

[snatcher]

I suggest you let some time pass and see if this goes anywhere.

[datiswous]

X-ray glasses is a core feature, so I think the fix should be applied to core. I suggest opening a bug report with your fix.

[wesp5]

Is this really a core feature yet? Because I looked for the script in version 2.11 and I can't find it except in the missions.

Edited July 30, 2023 by wesp5

[Wellingtoncrab]

I believe the xray materials are what is in core. The def and scripts might still need to be made though there is an entry on the wiki which provides instructions:

https://wiki.thedarkmod.com/index.php?title=Xrays

https://wiki.thedarkmod.com/index.php?title=Xrays_in_GUIs

[wesp5]

Maybe it is enough to edit that one line in the missions that already have them and also in the wiki entry to fix the inventory issue! I don't have access there, but maybe Snatcher has?

Edited July 30, 2023 by wesp5

[snatcher]

6 hours ago, wesp5 said:

I don't have access there, but maybe Snatcher has?

I detected something and I presented the case and I provided a working, tested alternative. My part is done! Up to you now, guys.