Jump to content
The Dark Mod Forums

Recommended Posts

Posted

Hmm... it's not just edge case assets, but health potions and special arrows all have transparent components. Since the problems areas would be portions of a material which are fully transparent - not sure if there would be a way for the shader to tell the difference between those and say these types of glass surfaces?

 

-=  IRIS  =-    ♦    = SLL =

  • nbohr1more changed the title to [ 2.10 ] New Frob Shader
Posted
16 hours ago, STiFU said:

We have too many new frob shader threads. 😄 I count 2 public and 2 internal.

Most can't see the top secret ones which are for inner circle eyes only... 🧐

And frobbing is a pretty important mechanic which is hard to get right and is perceived to work pretty good in current stable by most players. So it is hard to improve.

If you want to know the real potential maximum count of frob highlight threads, just ship the depth-ignoring glow version to stable users.
A mere two really isn't that much... 😇

  • 4 weeks later...
Posted
8 minutes ago, duzenko said:

Is the outline supposed to work for both old and new backend? I think it should though I vaguely remember something only working in new backend

It seems frob outline does not work in old backend right now.

Posted

I very much like the new implementation! Sharper and more accurate in many ways. Unfortunately it will not help much with geometry reliant on alpha textures, that might look ugly for a handful of assets.

Only one issue I'm seeing so far: It's causing bright speckles at least with my bloom settings. If it's shader based the outline should probably be processed after bloom not before it.

nvdmfvi.jpg
sXTtmxe.jpg

  • Like 2
  • Thanks 1
Posted (edited)
11 minutes ago, MirceaKitsune said:

Only one issue I'm seeing so far: It's causing bright speckles at least with my bloom settings.

nvdmfvi.jpg
 

I haven't tried this myself yet, but just looking at this screenshot makes me dislike it again. I don't know if this is due to your bloom settings or not, but do you see all the big white pixels in the almost vertical lines that look completely gamey? They kill the atmosphere big time!

Edited by wesp5
Posted
20 hours ago, wesp5 said:

I haven't tried this myself yet, but just looking at this screenshot makes me dislike it again. I don't know if this is due to your bloom settings or not, but do you see all the big white pixels in the almost vertical lines that look completely gamey? They kill the atmosphere big time!

r_froboutlinecolora 0

  • Like 1
  • Sad 1

I always assumed I'd taste like boot leather.

 

Posted
20 minutes ago, MirceaKitsune said:

Only one issue I'm seeing so far: It's causing bright speckles at least with my bloom settings. If it's shader based the outline should probably be processed after bloom not before it.

Wow, sparklies! 🤣

Yes, bloom is applied after outline, and most likely it will remain so.

You can set "r_frobOutlineColorA 2" instead of "r_frobOutlineColorA 5": the outline will still look hard, but I don't get these uberlights on highest bloom settings.
It can be fixed properly of course, allowing to reduce r_frobOutlineColorA down to 1, but that would need code fix.

  • Like 1
Posted
3 minutes ago, stgatilov said:

Wow, sparklies! 🤣

Yes, bloom is applied after outline, and most likely it will remain so.

You can set "r_frobOutlineColorA 2" instead of "r_frobOutlineColorA 5": the outline will still look hard, but I don't get these uberlights on highest bloom settings.
It can be fixed properly of course, allowing to reduce r_frobOutlineColorA down to 1, but that would need code fix.

Thanks: That would explain why I'm getting it with preset 1 whereas 2 mitigates it. I'd default the alpha to a lower value then if possible, the highlight is pretty solid anyway and less intensity may look better.

Posted
57 minutes ago, MirceaKitsune said:

I very much like the new implementation! Sharper and more accurate in many ways. Unfortunately it will not help much with geometry reliant on alpha textures, that might look ugly for a handful of assets.

Only one issue I'm seeing so far: It's causing bright speckles at least with my bloom settings. If it's shader based the outline should probably be processed after bloom not before it.

nvdmfvi.jpg
sXTtmxe.jpg

This looks amazing! Now we just need some more pbr! So good!

  • Like 1
  • Haha 1

Can we have more scary Zombie Horror maps?

Posted
2 hours ago, stgatilov said:

This is (or soon will be) not an option, if you want to avoid the issue when an item is frobable but does not highlight at all.

What does that mean? Wasn't it planned to replace the frob-helper-option with a remove-outline-option anyway?

Posted
6 minutes ago, wesp5 said:

What does that mean? Wasn't it planned to replace the frob-helper-option with a remove-outline-option anyway?

The main plan is to remove frob-highlight stages from materials.

It seems that it is not possible to implement a universal rule for highlighting all objects. The current rule works fine in 99% cases, but there are some objects which don't react. The outline is here to help with these cases.

So... please stop saying "just disable outline!", don't ignore the problem.

  • Like 2
Posted (edited)
3 hours ago, stgatilov said:

It seems that it is not possible to implement a universal rule for highlighting all objects. The current rule works fine in 99% cases, but there are some objects which don't react. The outline is here to help with these cases.

So... please stop saying "just disable outline!", don't ignore the problem.

So because of maybe 1% of objects we will get artifacts like in the attached screenshot for basically every door? And each highlighted object will show the blockyness of the models as if we are playing a retro shooter? What is the sense in that?

bakery_job_2021-10-11_21.56.25.jpg

Edited by wesp5
  • Like 4
Posted
6 hours ago, stgatilov said:

The main plan is to remove frob-highlight stages from materials.

It seems that it is not possible to implement a universal rule for highlighting all objects. The current rule works fine in 99% cases, but there are some objects which don't react. The outline is here to help with these cases.

So... please stop saying "just disable outline!", don't ignore the problem.

As the outline is the problem, "just disable outline!" actually is the fix. The old highlighting has its flaws in bright environments - but it still almost always worked just fine.
So the new highlighting but without the outline should work just fine as well.

Posted

Glad to see the outline back! I think it's great personally. I tested out the three presets and only seemed to run into bugs with the first one, like these boxes would periodically appear around bound items (in this case door knobs):

FirstNight_2021-10-11_17_03_13.thumb.jpg.363aa94c498d12455794b14694178396.jpg

FirstNight_2021-10-11_17_11_34.thumb.jpg.ddc26543cbb921de6e1f3eaca7d212e1.jpg

Couldn't get it to repeat on present 2 or 3 - which I would say as far as appearance I prefer both of those options over the hard outline of 1 anyhow. I am partial to the smoother falloff of the image based preset 3 as I think it looks the best and seemed to provide the most consistent results in my experience but I will keep testing as see if I run into anything.

I was also happy the see the base frob highlight seems to play much nicer on items with transparent components like gravestones or the potions I posted above. 

It can be very frustrating to discover you could not make an object interactable so I just want to say I really appreciate the effort towards covering everything!

  • Like 1

-=  IRIS  =-    ♦    = SLL =

Posted

I think this is a general issue with our bloom implementation.

I created a water material that also exhibited these types of artifacts.

I believe we need to ensure either input or output values are clamped so they do not go out-of-range.

We probably should cure this sooner than later because if I bump into artifacts with my own water

material chances are other mappers (etc) may bump into this issue as well.

  • Like 2

Please visit TDM's IndieDB site and help promote the mod:

 

http://www.indiedb.com/mods/the-dark-mod

 

(Yeah, shameless promotion... but traffic is traffic folks...)

Posted
8 hours ago, wesp5 said:

So because of maybe 1% of objects we will get artifacts like in the attached screenshot for basically every door? And each highlighted object will show the blockyness of the models as if we are playing a retro shooter? What is the sense in that?

Well... any outline will make mesh geometry more visible.

As for partly visible pixels: that's the price for respecting depth, I'm afraid.

Posted
5 hours ago, Abusimplea said:

So the new highlighting but without the outline should work just fine as well.

spawn atdm:moveable_flask1

Highlighting with plain white will make things look milky. Highlighting with diffuse texture does not work for some specular objects. There is no universal rule to highlight everything, I'm afraid.

 

Posted (edited)
2 hours ago, stgatilov said:

There is no universal rule to highlight everything, I'm afraid.

Still there should be an option to turn the outline off for those of us that want the better atmosphere and not the easy hightlights. After all with a little bit of experience you could probably figure out what to frob without any highlights...

Edited by wesp5
  • Like 1
  • Sad 1

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.


  • Recent Status Updates

    • jivo

      I just uploaded a new version of the Visible Player Hands mod. It's been updated for TDM 2.13 and has new animations. Check out the post if you're interested!
      · 0 replies
    • datiswous

      I moved from Manjaro Linux (rolling release) to Linux Mint (LTS). One of the reasons was that I found the updates a bit too often and long. But now on Mint I get updates every day, although they're usually small updates.
      · 3 replies
    • JackFarmer

      "Hidden Hands: Vitalic Fever" - new update available including subtitles & compressed briefing video (thanks to @datiswous) and several fixes.
      · 0 replies
    • Wolfmond

      🇬🇧

      2025-04-20
      I'd like to track my level design progress a bit more often now, so I'm using the feed in my profile here.
      I've been working intensively on Springheel's YouTube course over the past few days. I'm currently up to lesson 8. There is so much information that needs to be processed and practiced. 
      I have started to create my own house. As I don't have the imagination to create a good floor plan, I grabbed a floor plan generator from Watabou and experimented with it. I chose a floor plan that I will modify slightly, but at least I now have an initial idea. 
      I used two guards as a measuring tape: The rooms are two guards high. It turned out that I can simply double the number of boxes in DarkRadiant in grid size 8 that are drawn in the floor plan. 
      I practiced the simplest things on the floor plan first. Drawing walls, cutting walls, inserting doors, cutting out frames, creating VisPortals, furnishing rooms.
      I have had my first success in creating a book. Creating a book was easier than I thought. I have a few ideas with books. The level I'm creating will be more or less a chill level, just for me, where I'll try out a few things. I don't have an idea for my own mission yet. I want to start small first.
      For the cellar, I wanted to have a second entrance, which should be on the outside. I'm fascinated by these basement doors from the USA, I think they're called Bilco basement doors. They are very unusual in Germany, but this type of access is sometimes used for deliveries to restaurants etc., where barrels can be rolled or lifted into the cellar. 
      I used two Hatch Doors, but they got completely disoriented after turning. I have since got them reasonably tamed. It's not perfect, but it's acceptable. 
      In the cellar today I experimented with a trap door that leads to a shaft system. The rooms aren't practically finished yet, but I want to continue working on the floor plan for now. I'll be starting on the upper floor very soon.

      __________________________________________________________________________________
      🇩🇪

      2025-04-20

      Ich möchte nun mal öfters ein bisschen meinen Werdegang beim Leveldesign tracken, dazu nutze ich hier den Feed in meinem Profil.
      Ich habe mich in den vergangenen Tagen intensiv mit dem Youtube-Kurs von Springheel beschäftigt. Aktuell bin ich bis zu Lektion 8 gekommen. Das sind so viele Informationen, die erstmal verarbeitet werden wollen und trainiert werden wollen. 

      Ich habe mich daran gemacht, ein eigenes Haus zu erstellen. Da mir die Fantasie fehlt, einen guten Raumplan zu erstellen, habe ich mir einen Grundrissgenerator von Watabou geschnappt und damit experimentiert. Ich habe mich für einen Grundriss entschieden, den ich noch leicht abwandeln werde, aber zumindest habe ich nun eine erste Idee. 

      Als Maßband habe ich zwei Wächter genommen: Die Räume sind zwei Wächter hoch. Es hat sich herausgestellt, dass ich in DarkRadiant in Gittergröße 8 einfach die doppelte Anzahl an Kästchen übernehmen kann, die im Grundriss eingezeichnet sind. 

      Ich habe bei dem Grundriss erstmal die einfachsten Sachen geübt. Wände ziehen, Wände zerschneiden, Türen einsetzen, Zargen herausschneiden, VisPortals erstellen, Räume einrichten.

      Ich habe erste Erfolge mit einem Buch gehabt. Das Erstellen eines Buchs ging leichter als gedacht. Ich habe ein paar Ideen mit Bücher. Das Level, das ich gerade erstelle, wird mehr oder weniger ein Chill-Level, einfach nur für mich, bei dem ich ein paar Sachen ausprobieren werde. Ich habe noch keine Idee für eine eigene Mission. Ich möchte erst einmal klein anfangen.

      Beim Keller wollte ich gerne einen zweiten Zugang haben, der sich außen befinden soll. Mich faszinieren diese Kellertüren aus den USA, Bilco basement doors heißen die, glaube ich. Diese sind in Deutschland sehr unüblich, diese Art von Zugängen gibt es aber manchmal zur Anlieferung bei Restaurants etc., wo Fässer dann in den Keller gerollt oder gehoben werden können. 
      Ich habe zwei Hatch Doors verwendet, die allerdings nach dem Drehen vollkommen aus dem Ruder liefen. Inzwischen habe ich sie einigermaßen gebändigt bekommen. Es ist nicht perfekt, aber annehmbar. 
      Im Keller habe ich heute mit einer Falltür experimentiert, die zu einem Schachtsystem führt. Die Räume sind noch quasi nicht eingerichtet, aber ich möchte erstmal am Grundriss weiterarbeiten. In Kürze fange ich das Obergeschoss an.



      · 2 replies
    • JackFarmer

      On a lighter note, thanks to my cat-like reflexes, my superior puzzle skills and my perfect memory, I was able to beat the remastered version of "Tomb Raider: The Last Revelation" in a new superhuman record time of 23 h : 35 m, worship me!
      · 5 replies
×
×
  • Create New...