Beta Testing 2.09

[kingsal]

I noticed this in snowed inn. It looks like some readables, scroll_print_carleton.gui in this case, are cutting off the last line in the xdata string : 

I dont remember this happening before so I think this is a 2.09 bug.

In game ("lord builder" is missing) : 

[kingsal]

Correction- the above does happen in 2.08 so this is a bug with these guis. Will investigate further.

[kingsal]

@stgatilov Main menu music in snowed inn is commented out? Its no longer player the custom music we put in there. I assume this was done while you were reworking the main menu stuff?  What is the proper way for authors to play custom menu music now?

[MirceaKitsune]

Confirming the latest beta fixed AntiAliasing for me as well, nice to have it working again The mirror bug I'm experiencing with my FM is still there although I think it looks a little different now.

[peter_spy]

I have a setup with mirror, visportal, and portal sky leading to a skybox, no issues either on 2.08 or latest 2.09. There's something wrong on your end. Either the mirror setup is wrong (check limitations), or the invisible asset is the issue (brush, model, or its material).

Edited December 29, 2020 by peter_spy

[MirceaKitsune]

I wonder if the mirror might be interacting badly with the ceiling texture I'm using, textures/darkmod/stone/flat/slate01_light: Maybe that shader has something the mirror doesn't like in mixture with a skybox? But since others can't reproduce this one there's no point in dwelling over it, it may be a random map bug that could go away after I tweak things.

Speaking of mirrors: I tried giving the floor on my test map the newly updated textures/washroom/mirror texture. It seems mirror floors work perfectly and without issues All characters and entities are reflected, no flickering or clipping or anything, even the player sees theirself! This will be fun to attempt in some cathedrals or other buildings if performance allows.

 

Spoiler

 

[lowenz]

On 12/28/2020 at 11:33 AM, Araneidae said:

I would like to help debug the broken tonemap rendering on my system (my graphics card is old, a ten year old Radeon HD 6950, but the drivers are fully up to date, Fedora 23).  I think we've established that tonemap.fs itself is not introducing the problem, so I imagine the problem is upstream of that at the point where the choice is made whether or not to include tonemap in the processing chain.  I'm afraid I don't know much of the details of OpenGL or the graphics card rendering chain.

Beta 2.09-2 doesn't change anything for me.  I seem to remember that in release 2.08 I could control gamma, but the little preview popup was not available, so I guess that something in 2.09 has broken things.  Indeed, we did a bisect at the start of this chain!

I'm available to assist with tests this week, but will be back at work from Monday in the new year.  Should this conversation be moved to a new thread or a bug report ticket?

Maybe related!

 

https://www.phoronix.com/scan.php?page=news_item&px=AMDGPU-FP16-DCE8-Patches&utm_source=feedburner&utm_medium=feed&utm_campaign=Feed%3A+Phoronix+(Phoronix)

[cabalistic]

@Araneidae You could try to change the color precision to 32 bits (either in the menu or by setting `r_fboColorBits 32` via the console or in your darkmod.cfg. Perhaps we don't have proper detection for 64 bit color buffer support right now, and that messes things up if your card doesn't actually support is, as lowenz's post suggests?

Although I wouldn't really understand how disabling tonemapping could influence this, but who knows...

[Araneidae]

1 hour ago, cabalistic said:

@Araneidae You could try to change the color precision to 32 bits (either in the menu or by setting `r_fboColorBits 32` via the console or in your darkmod.cfg. Perhaps we don't have proper detection for 64 bit color buffer support right now, and that messes things up if your card doesn't actually support is, as lowenz's post suggests?

Although I wouldn't really understand how disabling tonemapping could influence this, but who knows...

Fantastic!  This works!!

The in-game gamma adjustment preview works now as well (this got turned off a release or two ago).

[cabalistic]

Alright, thanks for testing. And thanks to @lowenz to find the relevant clue

I'll ensure we add proper detection for 64 bit support so that it isn't enabled on systems that don't support it.

[lowenz]

Just my luck!

[stgatilov]

On 12/29/2020 at 1:34 AM, kingsal said:

@stgatilov Main menu music in snowed inn is commented out? Its no longer player the custom music we put in there. I assume this was done while you were reworking the main menu stuff?  What is the proper way for authors to play custom menu music now?

I tried to merge only those GUI changes which "surely won't break anything". The big story (about expanding supported ways of customization and removing unsupported from FMs) lives in its own branch, and is delayed for 2.10. So if something broken, it is unintentional. On the other hand, the state of menu GUI is such that touching it slightly in one place often leads to many unrelated things broken, so no surprise

I tried it in 2.08: I see snow animation, but the music is default one.

I think the proper way was and still is uncommenting these lines:

// Uncomment this to override the default menu music
//#undef MM_MENU_SOUND_CMD
//#define MM_MENU_SOUND_CMD "music tdm_mainmenu_background_music;"

// Uncomment this to override the default in-game menu music
//#undef MM_INGAME_MENU_SOUND_CMD
//#define MM_INGAME_MENU_SOUND_CMD "music tdm_objectives;"

In Snowed Inn, these lines are commented...

[MirceaKitsune]

No obvious bugs that I can see in the latest 2.09 beta. I just realized the first beta had yet another bug I missed: Ambient music also played at half volume and I could barely hear it... it now plays at the correct intensity again.

This might not be 2.09 specific per say, but I should point out I still keep seeing guards getting stuck in front of doors every once in a while. By stuck I mean they will open the door, but then spin in a circle in front of it even 10 times in a row, before either deciding to walk away or finally go through. I've seen it on more than one FM and with the default door / doorframe models.

[kingsal]

@stgatilovGood to know. We might want to look at FMs that include those files and double check to make sure their custom MM music plays. 
 

@MirceaKitsuneThats a classic TDM bug and as far as I can tell has something to do with door placement and giving the AI enough room to open doors, it could be other things though. It’s probably not a 2.9 bug but I’ll keep and eye out for it. 

[nbohr1more]

@cabalistic

When "r_useBindlessTextures" is enabled, changing AF during a mission via the menu results in a noticeable freeze when returning to the mission and several stutters or momentary freezes afterwards. I presume this is a byproduct of having to re-initialize the bindless textures?

Restarting fixes the stutter.

Is there a way to make this more graceful or is this a limitation of this feature?

[cabalistic]

3 minutes ago, nbohr1more said:

Is there a way to make this more graceful or is this a limitation of this feature?

Please add a bugtracker item for me. When textures are made bindless, texture parameters can no longer be changed for those textures. Changing AF or other parameters with bindless may require recreating the textures.

[nbohr1more]

16 minutes ago, cabalistic said:

Please add a bugtracker item for me. When textures are made bindless, texture parameters can no longer be changed for those textures. Changing AF or other parameters with bindless may require recreating the textures.

Done:

https://bugs.thedarkmod.com/view.php?id=5476

[Amadeus]

3 hours ago, kingsal said:

We might want to look at FMs that include those files and double check to make sure their custom MM music plays. 

I just took a look at A Good Neighbor and the custom MM music works fine in 2.09 Beta 2

[dynamix]

Just tested out beta-02, seems to work fine generally but I was messing around with the graphics settings to compare performance and after swapping between maps/stencil shadows there's a visible artifact in the middle of the screen with ambient occlusion enabled.

 

AMD RX580 latest drivers.

[AluminumHaste]

I do sometimes get that, some buffer has data in it that needs to be cleared I think.

Restarting TDM should get rid of that, or vid_restart in the console sometimes works.

[AluminumHaste]

55 minutes ago, dynamix said:

Just tested out beta-02, seems to work fine generally but I was messing around with the graphics settings to compare performance and after swapping between maps/stencil shadows there's a visible artifact in the middle of the screen with ambient occlusion enabled.

 

AMD RX580 latest drivers.

When you are using stencil shadows, open the console and type r_usebindlesstextures 1 and hit enter.

What does your image look like?

[lowenz]

Possible the same bindless textures issue that's not really an issue. It's a limit of the method.

[dynamix]

15 minutes ago, AluminumHaste said:

When you are using stencil shadows, open the console and type r_usebindlesstextures 1 and hit enter.

What does your image look like?

I did a quick test with this setting, it was already set to 1 for me so I set it to 0 and after a vid_restart I couldn't get it to bug out again.

I didn't try it a lot of times because vid_restart takes a long time for me but seems like it could be related to that setting.

[duzenko]

Minor: The default normal difficulty is not highlighted by default in GUI

[MirceaKitsune]

Since the beta is an opportunity to fix issues, including ones that existed in 2.08: Is there a chance for alt-tab switching under Linux / KDE to be fixed? I'm referring to this bug:

https://bugs.thedarkmod.com/view.php?id=5293

Alt-tabbing itself works fine. But if you switch to another window, moving the mouse cursor over the TDM window in the background causes it to jump in the middle of the screen. This is normal when the window is focused but shouldn't happen when something else is selected and you only move the cursor across to operate other applications.